If there are no objections (in time before I actually do it) I will make a branch and make the small change described here as my first (of I expect many) commits on that branch.
If there is any disagreement on details (rather than overall objection to the change), please tell me that as well. There are conditions under which the magnifier for the selected point in the control points dialog gets hidden without the point being deselected. As a user, I find that very inconvenient. Bruno seemed to agree in earlier discussion. On occasion, I really want to hide the magnifier. But there is no correlation between when it gets hidden by current code and when I want it hidden. I want to add a key (my choice would be 'm') that will temporarily hide the magnifier if it wasn't hidden and will bring it back if it was. Hiding would only be temporary: other actions make the magnifier appear and "hiding" would not suppress that. I would entirely remove the timer. It's only purpose is to hide the magnifier. I see no logic to when that timer is used vs. not used. Maybe the original intent was to always have that timer (never let the magnifier stay in view for over 2 seconds). As a user I see* zero* value in timer based hiding of the magnifier. But if others strongly disagree, (with significantly more work) I could invent a setting to allow that feature to be disabled (rather than take the feature away from everyone). With my limited understanding of mercurial, I was able to see the timer feature was added by ippei in commit 91503d5bebff I don't know this environment well enough to know how to find out who ippei is nor to find out when/why that commit was made. I also want to remove all other existing logic for hiding the magnifier, such as hiding it when the image itself is zoomed 200%. Subject to having a control point selected to be magnified, I want the new 'm' key operation to be the only thing that hides the magnifier. Separately, I want to commit my changes adding 400% and 800% zoom and my changes adjusting the magnifier for higher zoom. I expect the purpose of removing the magnifier at 200% zoom is that it isn't much extra magnification. But I both still would want it even if it was only a little extra and want to increase how much extra it is. Separately, I think the controls over the magnifier that are only in the registry on Windows (and I haven't looked for where they are on Fedora) ought to be in the GUI settings so they can be changed without regedit (I'm very comfortable with regedit but I expect most Windows Hugin users aren't). At the same time a bit more control should be included. I would tend to want to pretest and commit all those and related features all together. But I have been warned that doing so would make things too hard for whoever reviews/merges my changes. So I think the right size first chunk is just the changes related to hiding the magnifier. -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to hugin-ptx+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/22486fd0-4c32-43c2-ad90-49c45c4a7cfbn%40googlegroups.com.
