On Mon, 2009-08-03 at 02:16 +0200, m.wolkst...@gmx.de wrote:
> i think people who create songs by mixing patterns will get a large
> enrichment with this feature.
Hi Wolke, thanks for trying this out. This feature has been nagging at
me for a while now, so I'm glad I finally wrote it :).
> i will test the patch a bit more, because crashes and so on. but i think we
> must commit
> your patch absolutely into the branch.
Please tell me if there's any problems with it. It's pretty straight
forward.. the only bit I'm unhappy with is the duplication of the
computeVirtualPatternTransitiveClosure(). I'm still building my mental
architectural map of the code, so if there's a better place to refactor
that method into, please let me know.
> > Known Issues:
> >
> > - The UI could be better
> but imo its works perfect. and is easy to understand.
The ui is pretty simple, I'm just picking on the lack of spacing above
the listbox. I've never used Qt Designer before, or written Qt code
before, so it didn't end up looking quite like what I was wanting. Of
course, I didn't spend that much time tweaking it, either :).
> > - I ran uic manually to generate the new dialog's header.. is this done
> > automatically somewhere?
> hmm, i have no problems here. the ui_VirtualPatternDialog_UI.h will generated
> automatically.
Strange.. it didn't seem to be generating for me. If it works for you
and others, then I'm not too worried.
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Hydrogen-devel mailing list
Hydrogen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
