On 03/07/2014 17:16, Naoto Sato wrote:
With the original test case, webrev.1 and webrev.2 both succeed. With the modified test case (in webrev.2), webrev.1 fails but webrev.2 succeeds. The reason I changed the test case is to catch possible regression where someone makes changes to the SharedSecret being initialized at BidiBase class loading time (as in webrev.1).
I'm not sure that I get this, it actually looks to me that this change to the test could mask a problem with a future change that would break the shared secrets setup.

-Alan

Reply via email to