Hi Naoto, The change looks OK. One thought was whether any thought was given to use SkippedException in the else block starting at line 370 within LocaleProviders.
Best Lance > On Jan 6, 2020, at 12:05 PM, naoto.s...@oracle.com wrote: > > Hi, > > Please review the fix to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8236495 > > The proposed changeset is located at: > > https://cr.openjdk.java.net/~naoto/8236495/webrev.00/ > > The test case for the fix to 8232860 was only intended for the US locale. > Simply adding the default locale check will fix the test case. > > Naoto <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
