Hi Naoto > On Jan 6, 2020, at 12:55 PM, naoto.s...@oracle.com wrote: > > Hi Lance, > > Thank you for the prompt review. > > On 1/6/20 9:14 AM, Lance Andersen wrote: >> Hi Naoto, >> The change looks OK. One thought was whether any thought was given to use >> SkippedException in the else block starting at line 370 within >> LocaleProviders. > > I am not familiar with that exception. Is it jtreg.SkippedException?
Yes I am, sorry for not being clearer. You can throw that in the else block where you print the message about skipping the test and it will be tracked as a skip vs a pass. Not a big deal either way but gives you extra granularity as to why the test was not run and easier to see vs just a print statement… I just wanted to point this out as something to consider going forward. Have a good rest of your day! > I searched for the exception, and one example is: > > jdk/java/nio/channels/DatagramChannel/PromiscuousIPv6.java > > where it requires the platform is linux with the directive "@requires > os.family == "linux"", so throwing the exception does work as an assertion. > However in this LocaleProviders.java, it will need to simply ignore the case > and should succeed. So I am not sure SkippedException can be applied here. > > Naoto > >> Best >> Lance >>> On Jan 6, 2020, at 12:05 PM, naoto.s...@oracle.com >>> <mailto:naoto.s...@oracle.com> wrote: >>> >>> Hi, >>> >>> Please review the fix to the following issue: >>> >>> https://bugs.openjdk.java.net/browse/JDK-8236495 >>> >>> The proposed changeset is located at: >>> >>> https://cr.openjdk.java.net/~naoto/8236495/webrev.00/ >>> >>> The test case for the fix to 8232860 was only intended for the US locale. >>> Simply adding the default locale check will fix the test case. >>> >>> Naoto >> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| >> Principal Member of Technical Staff | +1.781.442.2037 >> Oracle Java Engineering >> 1 Network Drive >> Burlington, MA 01803 >> lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
