On Wed, 11 Oct 2023 12:12:09 GMT, Per Minborg <[email protected]> wrote:

>> This PR proposes to replace C-style array declarations with Java array 
>> declarations.
>
> Per Minborg has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix additional classes

AFAICT the icu code is integrated from an upstream project 
(https://github.com/unicode-org/icu/blob/main/icu4j/main/core/src/main/java/com/ibm/icu
 ?) - so modifying the code in the openjdk will make it harder to sync it up 
with the upstream project. If possible improvements should be done in the 
upstream project, otherwise perhaps not at all (unless absolutely necessary for 
functional purposes). @naotoj?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16146#issuecomment-1757656489

Reply via email to