On Wed, 11 Oct 2023 13:03:26 GMT, Claes Redestad <[email protected]> wrote:
>> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix additional classes > > AFAICT the icu code is integrated from an upstream project > (https://github.com/unicode-org/icu/blob/main/icu4j/main/core/src/main/java/com/ibm/icu > ?) - so modifying the code in the openjdk will make it harder to sync it up > with the upstream project. If possible improvements should be done in the > upstream project, otherwise perhaps not at all (unless absolutely necessary > for functional purposes). @naotoj? > Yes, I agree with @cl4es here. Unless some dire need to fix them ourselves, I > would leave them as they are. Otherwise, syncing with the upstream (which > coincidentally I am working on right now) would be more complex. Ok. I will close this PR and leave it to you then @naotoj . There are a number of missing `final` declarations for instance variables that are missing in many places so you could mop up those too. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16146#issuecomment-1758028751
