Hi Sonic, On Tue, 25 Mar 2008 11:01:18 +0800, Zhang, Sonic wrote: > I have already discussed your questions with you in attached email. See > bellow. The twi controller is designed to support SMBus protocol in > hardware. That's why we implement bfin_twi_smbus_xfer().
This is news to me, you did not tell this to me before. If there are hardware optimizations for SMBus then indeed it makes sense to have different code in the driver for I2C support and SMBus support. Still, I had several objections to the patch that was submitted in November 2007 (and resubmitted unchanged one week ago). I really would like to see them addressed. Thanks, -- Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
