Hi Jean, I just fixed rest issues in the twi driver according to your last comments in http://lists.lm-sensors.org/pipermail/i2c/2007-November/002121.html . Bryan will send you the latest patch.
Thank you for your suggestion. Sonic Zhang -----Original Message----- From: Jean Delvare [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 25, 2008 10:04 PM To: Zhang, Sonic Cc: Bryan Wu; [email protected] Subject: Re: [PATCH 1/6] Blackfin I2C/TWI driver: Add repeat start feature to avoid break of a bundle of i2c master xfer operation. Hi Sonic, On Tue, 25 Mar 2008 11:01:18 +0800, Zhang, Sonic wrote: > I have already discussed your questions with you in attached email. > See bellow. The twi controller is designed to support SMBus protocol > in hardware. That's why we implement bfin_twi_smbus_xfer(). This is news to me, you did not tell this to me before. If there are hardware optimizations for SMBus then indeed it makes sense to have different code in the driver for I2C support and SMBus support. Still, I had several objections to the patch that was submitted in November 2007 (and resubmitted unchanged one week ago). I really would like to see them addressed. Thanks, -- Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
