Defend the i2c refcount calls against NULL pointers, as is important
(and conventional) for such calls ... we don't want to morph NULL
pointers into bogus non-null ones. Note that none of the current
callers of i2c_use_client() use its return value.
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
---
drivers/i2c/i2c-core.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
--- g26.orig/drivers/i2c/i2c-core.c 2008-05-04 12:50:33.000000000 -0700
+++ g26/drivers/i2c/i2c-core.c 2008-05-04 12:51:04.000000000 -0700
@@ -1013,8 +1013,9 @@ EXPORT_SYMBOL(i2c_detach_client);
*/
struct i2c_client *i2c_use_client(struct i2c_client *client)
{
- get_device(&client->dev);
- return client;
+ if (client && get_device(&client->dev))
+ return client;
+ return NULL;
}
EXPORT_SYMBOL(i2c_use_client);
@@ -1026,7 +1027,8 @@ EXPORT_SYMBOL(i2c_use_client);
*/
void i2c_release_client(struct i2c_client *client)
{
- put_device(&client->dev);
+ if (client)
+ put_device(&client->dev);
}
EXPORT_SYMBOL(i2c_release_client);
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
