One thing I forgot in my initial review:
On Thu, 15 May 2008 22:36:39 +0200, Wolfram Sang wrote:
> + /* Use I2C operations unless we're stuck with SMBus extensions. */
> + if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
> + if (chip->flags & AT24_EE_ADDR2) {
> + err = -ECOMM;
> + goto fail;
> + }
> + if (!i2c_check_functionality(client->adapter,
> + I2C_FUNC_SMBUS_I2C_BLOCK)) {
> + err = -EBADMSG;
> + goto fail;
> + }
> + use_smbus = true;
> + }
For a read-only EEPROM, you only need I2C_FUNC_SMBUS_READ_I2C_BLOCK,
not I2C_FUNC_SMBUS_I2C_BLOCK. It would matter if the underlying adapter
supports I2C block read but not I2C block write.
--
Jean Delvare
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
