Russell King - ARM Linux wrote: > On Fri, Aug 01, 2008 at 11:06:12AM +0100, Jonathan Cameron wrote: >> Ben Dooks wrote: >>> On Thu, Jul 31, 2008 at 04:56:53PM +0100, Jonathan Cameron wrote: >>>> From: Jonathan Cameron <[EMAIL PROTECTED]> >>>> >>>> Add fast_mode option to i2c_pxa_platform_data and use it to set the ICR_FM >>>> bit >>>> appropriately when i2c_pxa_reset is called. Parameter called fast_mode >>>> rather >>>> than frequency as this driver is also used for the i2c_pxa_pwr bus which >>>> has >>>> different normal and fast frequencies. >>>> >>>> Signed-off-by: Jonathan Cameron <[EMAIL PROTECTED]> >>>> -- >>>> This is basically a repost of the original patch with use_pio and >>>> fast_mode converted >>>> to bit fields as suggested / agreed by Eric Miao and Ben Dooks. >>> please ensure your descriptions are wrapped to less than 77 characters >>> per line. >> Will do, sorry about that bit of carelessness. > > Less than 72 is preferable - because tools (eg, git log) commonly prefix > the comments with one tab. Doh, emails crossed. I'll repost with 72 character limit in a sec! > >> Not something I care about that much either way and I'm guessing by >> the would be nice that you don't either. I'll repost the patch without. > > Preferred without the space. Thanks for clearing that up. -- Jonathan
_______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
