Dean, I would recommend that you remove any dead code in your ACS routines. It isn't that difficult to add it in at the appropriate time and it removes any confusion when the routines are read by someone else.
Also, I totally agree with the suggestion someone made to remove the compound tests for valid DASD units and place a single entry test at or near the top of your selection logic. When I coded ACS routines, I tried to stay within a framework on the selection logic that performed tests for most inclusive/exclusive to least inclusive/exclusive. I tested for a valid storage class first, handled special processing second (including the logic to not assign a storage class), handled valid DASD and TAPE units, handled Job names, program names, DDNAMEs, etc. Lastly, I coded dataset and volser logic. I also documented each section with comments so there was no confusion as to what each select, when statements were trying to accomplish. Bob Richards -----Original Message----- From: IBM Mainframe Discussion List [mailto:[EMAIL PROTECTED] On Behalf Of Dean Montevago Sent: Wednesday, August 22, 2007 9:56 AM To: [email protected] Subject: Re: SMS Question - Urgent Thank you for bringing this to my attention. These are the filterlists I have defined: FILTLIST DASD_UNITS INCLUDE('3390','SYSDA','SYSALLDA', '') FILTLIST TAPE_UNITS INCLUDE('3590*','MAGSTAR','T3590') FILTLIST DB2_VOL INCLUDE(* ) In the select logic I check for the dataset name being passed and the DASD units. So could I get burned by this example ? We don't SMS manage any tape and the filter list defined for the tape units is no where in the logic. We just defined it in the event we might use it someday. LEGAL DISCLAIMER The information transmitted is intended solely for the individual or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of or taking action in reliance upon this information by persons or entities other than the intended recipient is prohibited. If you have received this email in error please contact the sender and delete the material from any computer. SunTrust and Seeing beyond money are federally registered service marks of SunTrust Banks, Inc. [ST:XCL] ---------------------------------------------------------------------- For IBM-MAIN subscribe / signoff / archive access instructions, send email to [EMAIL PROTECTED] with the message: GET IBM-MAIN INFO Search the archives at http://bama.ua.edu/archives/ibm-main.html
