Willie,

Sorry for the delay in responding. Had several doctor appointments
yesterday.

Scott and Tom identified your immediate problem, but your routine still
could use some improvement. As was pointed out, be consistent and use
DO-SET-EXIT-END loops for *ALL* storage class assignments. Document your
logic choices and decisions with better comments.

There is an ELSE statement that is hanging out there by itself before
the SELECT statement should not be there and is poor coding. The only
reason it works is because the ACSENVIR test satisfies the ELSE
condition more often than the IF condition, enabling the SELECT logic
below it to execute. Remove the ELSE statement.

Hope this helps.

Bob   

-----Original Message-----
From: IBM Mainframe Discussion List [mailto:[EMAIL PROTECTED] On
Behalf Of willie bunter
Sent: Tuesday, April 29, 2008 10:41 AM
To: [email protected]
Subject: Re: SMS PUZZLE

Robert,
   
  Thanks for your offer to take a look at the code.  I have enclosed it.
I hope you can find the bug.

  Thanks in advance for your help.
   
  
"Richards, Robert B." <[EMAIL PROTECTED]> wrote:
  Willie,

No, the unit is not the problem, as it is valid in both tests. Your
logic must honor (ie, allow) specific dataset placement when a volser is
coded. It may be part of a compound test.

Most of the time, the ACS routines rely on the coder knowing the
sequence of the logic tests and coding them appropriately for the test
desired. Without seeing more of your SC routine, I would be speculating
on the correct answer.

If you want to send it to me, I'll take a look. 

Also, my personal preference is to use DO-END loops that SET the SC and
then EXIT when a test is satisfied. YMMV

-----Original Message-----
From: IBM Mainframe Discussion List [mailto:[EMAIL PROTECTED] On
Behalf Of willie bunter
Sent: Monday, April 28, 2008 2:26 PM
To: [email protected]
Subject: SMS PUZZLE

Hallo Everybody,

I am trying to track down why some dsns with the HLQ of TEST.** are
being directed to a non-SMS volume. I noticed that a majority of the
dsns are being allocated correctly by SMS. I ran a check on the ACS
routines and I found that the SC ACS has a storage class set for TEST.**
I also noticed that is another storage class for unit types. Could
this be the cause? I executed some tests where I used the unit=3390,
the dsn (TEST.AAA.BB) was then allocated with the proper storage class
and storage group. However, when I used the unit=3390 with the volser
of a non-SMS pack, the dsn (TEST.AAA.CC) was allocated on the pack
Below is a sample of the SC ACS.
FILTLIST VALUNIT INCLUDE
('3380','SYSDA','SYSALLDA','3390','PUBLIC',VVIO','PROD','TEST''' ) 

FILTLIST GDVX_DSN INCLUDE 
(LIBR.**, SCPX.SYST.*.VSAMEXT.**, 
TEST.**,TEST1.**,ALQTOPR.**, 
.................................
.................................))

WHEN (&UNIT NE &VALUNIT) 
SET &STORCLAS = '' 

WHEN (&HLQ = &POOL_GDVX OR &DSN = &GDVX_DSN) 
SET &STORCLAS = 'SCTEST' 

Am I on the right track in thinking that the SC VALUNIT is the cause
of the problem? If so, how can I fix it? I would appreciate your
suggestion and comments.

Thanks in advance.



---------------------------------
Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try
it now.

----------------------------------------------------------------------
For IBM-MAIN subscribe / signoff / archive access instructions,
send email to [EMAIL PROTECTED] with the message: GET IBM-MAIN INFO
Search the archives at http://bama.ua.edu/archives/ibm-main.html

----------------------------------------------------------------------
For IBM-MAIN subscribe / signoff / archive access instructions,
send email to [EMAIL PROTECTED] with the message: GET IBM-MAIN INFO
Search the archives at http://bama.ua.edu/archives/ibm-main.html



       
---------------------------------
Be a better friend, newshound, and know-it-all with Yahoo! Mobile.  Try
it now.

----------------------------------------------------------------------
For IBM-MAIN subscribe / signoff / archive access instructions,
send email to [EMAIL PROTECTED] with the message: GET IBM-MAIN INFO
Search the archives at http://bama.ua.edu/archives/ibm-main.html

----------------------------------------------------------------------
For IBM-MAIN subscribe / signoff / archive access instructions,
send email to [EMAIL PROTECTED] with the message: GET IBM-MAIN INFO
Search the archives at http://bama.ua.edu/archives/ibm-main.html

Reply via email to