Branch: refs/heads/1.5.y
Home: https://github.com/ibus/ibus
Commit: 0be4664b2ea3071c01ff479443033eb1accdfb03
https://github.com/ibus/ibus/commit/0be4664b2ea3071c01ff479443033eb1accdfb03
Author: fujiwarat <[email protected]>
Date: 2014-05-02 (Fri, 02 May 2014)
Changed paths:
M setup/setup.ui
Log Message:
-----------
Set max-width-chars property in ibus-setup wrapped GtkLabel.
If GtkWindow has 'resizable' property = FALSE, the wrap in GtkLabel
is not done automatically and need to set 'max-width-chars' property.
TEST=ibus-setup
Review URL: https://codereview.appspot.com/92940043
Commit: 318836a647460e28dcc682543a118567474f9854
https://github.com/ibus/ibus/commit/318836a647460e28dcc682543a118567474f9854
Author: Eike Hein <[email protected]>
Date: 2014-05-08 (Thu, 08 May 2014)
Changed paths:
M engine/simple.xml.in
Log Message:
-----------
Add the nodeadkeys variant of the German keyboard layout.
BUG=http://code.google.com/p/ibus/issues/detail?id=1710
Review URL: https://codereview.appspot.com/96040043
Patch from Eike Hein <[email protected]>.
Commit: 386bafb0b91a61d51385e0bba2b3fc4b1e2d9013
https://github.com/ibus/ibus/commit/386bafb0b91a61d51385e0bba2b3fc4b1e2d9013
Author: Ryu Changwoo <[email protected]>
Date: 2014-05-08 (Thu, 08 May 2014)
Changed paths:
M engine/simple.xml.in
Log Message:
-----------
Delete Korean keymap.
BUG=http://code.google.com/p/ibus/issues/detail?id=1708
Review URL: https://codereview.appspot.com/92090043
Patch from Ryu Changwoo <[email protected]>.
Commit: 34692850bd58543e016e35ea7c863d311ca92519
https://github.com/ibus/ibus/commit/34692850bd58543e016e35ea7c863d311ca92519
Author: fujiwarat <[email protected]>
Date: 2014-05-09 (Fri, 09 May 2014)
Changed paths:
M ui/gtk3/candidatepanel.vala
Log Message:
-----------
Let ibus-ui-gtk3 not to show zero-lenght preedit text.
preedit text is shown by ibus-ui-gtk3 on X11 applications
and do not have to show it likes GTK+ when the lenght is zero.
BUG=http://code.google.com/p/ibus/issues/detail?id=1709
TEST=ibus-ui-gtk3 with ibus-pinyin and x11 applications
Review URL: https://codereview.appspot.com/93150043
Commit: e6ee958b0120c4445c06db24ed7ac8f87675646e
https://github.com/ibus/ibus/commit/e6ee958b0120c4445c06db24ed7ac8f87675646e
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M src/Makefile.am
Log Message:
-----------
build-sys: Fix 'privite' typo in Makefile.am
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/102140044
Patch from Christophe Fergeau <[email protected]>.
Commit: 23c784d45cbab7ae7a12e7b3c02c4299a446e03b
https://github.com/ibus/ibus/commit/23c784d45cbab7ae7a12e7b3c02c4299a446e03b
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M src/ibusbus.h
Log Message:
-----------
Fix small typo in gtk-doc API doc
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/108740043
Patch from Christophe Fergeau <[email protected]>.
Commit: 87fb61f76fc0ffbac316b0090b206faadfbd82fd
https://github.com/ibus/ibus/commit/87fb61f76fc0ffbac316b0090b206faadfbd82fd
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M src/ibusbus.c
Log Message:
-----------
Fix GVariant leaks
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/109720043
Patch from Christophe Fergeau <[email protected]>.
Commit: f3e8aaff559e56efe54c43af123e0ab87a17423b
https://github.com/ibus/ibus/commit/f3e8aaff559e56efe54c43af123e0ab87a17423b
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M src/ibuscomponent.c
M src/ibusenginedesc.c
M src/ibusinternal.h
M src/ibusobservedpath.c
M src/ibusproperty.c
M src/ibusutil.c
Log Message:
-----------
Fix string leaks in deserialize vfuncs
When an object contains char * properties, its deserialize function will
overwrite these string values without freeing them first. They are not
necessarily NULL as they can have (default) values set upon construction,
so they need to be g_free'd before being overwritten.
For example, IBusEngineDesc::longname, IBusEngineDesc::description,
IBusEngineDesc::language, ... are all set to "" upon construction (instead of
NULL), so the corresponding IBusEngineDesc fields must be freed before
being overwritten during deserialization.
This commit introduces a ibus_g_variant_get_child_string() to do this
and set the string value.
This leak was reported by valgrind:
==22163== 59 bytes in 59 blocks are definitely lost in loss record 1,633 of
2,720
==22163== at 0x4A0645D: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==22163== by 0x56DFDF2: g_malloc (gmem.c:97)
==22163== by 0x56E011D: g_malloc_n (gmem.c:338)
==22163== by 0x56FAFCC: g_strdup (gstrfuncs.c:356)
==22163== by 0x546CDB8: g_value_dup_string (gvaluetypes.c:1136)
==22163== by 0x4E43A98: ibus_engine_desc_set_property (ibusenginedesc.c:385)
==22163== by 0x5446CA3: object_set_property (gobject.c:1378)
==22163== by 0x54484BB: g_object_constructor (gobject.c:2020)
==22163== by 0x4E24564: ibus_object_constructor (ibusobject.c:111)
==22163== by 0x5447577: g_object_new_with_custom_constructor (gobject.c:1645)
==22163== by 0x5447787: g_object_new_internal (gobject.c:1722)
==22163== by 0x5447C75: g_object_newv (gobject.c:1868)
==22163== by 0x544737A: g_object_new (gobject.c:1568)
==22163== by 0x4E2521C: ibus_serializable_deserialize
(ibusserializable.c:292)
==22163== by 0x4E480E0: ibus_component_deserialize (ibuscomponent.c:408)
==22163== by 0x4E2523E: ibus_serializable_deserialize
(ibusserializable.c:294)
==22163== by 0x4E4C1D1: ibus_registry_deserialize (ibusregistry.c:202)
==22163== by 0x4E4C95C: ibus_registry_load_cache_file (ibusregistry.c:362)
==22163== by 0x4E4C6A4: ibus_registry_load_cache (ibusregistry.c:302)
==22163== by 0x40EBCD: bus_ibus_impl_registry_init (ibusimpl.c:1871)
==22163== by 0x40C1D4: bus_ibus_impl_init (ibusimpl.c:424)
==22163== by 0x5460FCD: g_type_create_instance (gtype.c:1868)
==22163== by 0x5448466: g_object_constructor (gobject.c:2006)
==22163== by 0x4E24564: ibus_object_constructor (ibusobject.c:111)
==22163== by 0x5447577: g_object_new_with_custom_constructor (gobject.c:1645)
==22163== by 0x5447787: g_object_new_internal (gobject.c:1722)
==22163== by 0x54483C1: g_object_new_valist (gobject.c:1980)
==22163== by 0x54473C9: g_object_new (gobject.c:1571)
==22163== by 0x40E94A: bus_ibus_impl_get_default (ibusimpl.c:1807)
==22163== by 0x41D880: bus_server_init (server.c:100)
==22163== by 0x420E91: main (main.c:236)
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/104850043
Patch from Christophe Fergeau <[email protected]>.
Commit: 18687d77de1ad755db022e7da565dc8ad44ae5ac
https://github.com/ibus/ibus/commit/18687d77de1ad755db022e7da565dc8ad44ae5ac
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M src/ibusconfig.c
Log Message:
-----------
Fix g_dbus_proxy_get_name_owner() leaks
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/105830043
Patch from Christophe Fergeau <[email protected]>.
Commit: d0aaf7763d315161085aeaa00b6cdfa0e2569071
https://github.com/ibus/ibus/commit/d0aaf7763d315161085aeaa00b6cdfa0e2569071
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M src/ibusproperty.c
Log Message:
-----------
Fix GObject leaks in ibus_property_deserialize()
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/103100043
Patch from Christophe Fergeau <[email protected]>.
Commit: ca8cac8b95505140bc51d98d42c9af1122338920
https://github.com/ibus/ibus/commit/ca8cac8b95505140bc51d98d42c9af1122338920
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M src/ibusservice.c
Log Message:
-----------
Fix GDBusNodeInfo leak in ibus_service_class_add_interfaces
A call to g_dbus_node_info_unref was in place but commented out.
This fixes:
==20039== 424 (40 direct, 384 indirect) bytes in 1 blocks are definitely lost
in loss record 2,115 of 2,159
==20039== at 0x4A081D4: calloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==20039== by 0x56ECE69: g_malloc0 (gmem.c:127)
==20039== by 0x56ED191: g_malloc0_n (gmem.c:362)
==20039== by 0x519FBF2: parse_data_get_node (gdbusintrospection.c:1171)
==20039== by 0x519FFE1: parser_start_element (gdbusintrospection.c:1290)
==20039== by 0x56E9C2E: emit_start_element (gmarkup.c:1048)
==20039== by 0x56EA7CB: g_markup_parse_context_parse (gmarkup.c:1395)
==20039== by 0x51A1082: g_dbus_node_info_new_for_xml
(gdbusintrospection.c:1797)
==20039== by 0x4E33D38: ibus_service_class_add_interfaces (ibusservice.c:610)
==20039== by 0x4E32C24: ibus_service_class_init (ibusservice.c:213)
==20039== by 0x546EE85: type_class_init_Wm (gtype.c:2220)
==20039== by 0x5470586: g_type_class_ref (gtype.c:2935)
==20039== by 0x5470539: g_type_class_ref (gtype.c:2927)
==20039== by 0x5470539: g_type_class_ref (gtype.c:2927)
==20039== by 0x5454D21: g_object_new_valist (gobject.c:1906)
==20039== by 0x54543C9: g_object_new (gobject.c:1571)
==20039== by 0x402AF0: ibus_config_dconf_new (config.c:449)
==20039== by 0x401D59: ibus_dconf_start (main.c:61)
==20039== by 0x401E30: main (main.c:85)
==20039==~
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/100990043
Patch from Christophe Fergeau <[email protected]>.
Commit: f4d7ceafb588737212a21216cb30ccdc9ff02cdf
https://github.com/ibus/ibus/commit/f4d7ceafb588737212a21216cb30ccdc9ff02cdf
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M src/tests/ibus-engine-switch.c
Log Message:
-----------
Fix leak in ibus-engine-switch test
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/104860043
Patch from Christophe Fergeau <[email protected]>.
Commit: 0d17c2507d38e62a149f3fe7d32e6c3e7c3bcd0e
https://github.com/ibus/ibus/commit/0d17c2507d38e62a149f3fe7d32e6c3e7c3bcd0e
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M src/tests/ibus-config.c
Log Message:
-----------
tests/ibus-config: Fix typo in function name
"success" was misspelt "sucess"
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/102160043
Patch from Christophe Fergeau <[email protected]>.
Commit: 70ddaf10acce9eb96294a2513967042ecb2a91d4
https://github.com/ibus/ibus/commit/70ddaf10acce9eb96294a2513967042ecb2a91d4
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M bus/ibusimpl.c
M bus/inputcontext.c
M conf/dconf/config.c
M conf/gconf/config.c
M src/ibuscomponent.c
M src/ibusengine.c
Log Message:
-----------
Fix GVariantBuilder leaks
When using g_variant_builder_new(), we must call
g_variant_builder_unref() to free it:
"You should call g_variant_builder_unref() on the return value when it
is no longer needed. The memory will not be automatically freed by any
other call.
In most cases it is easier to place a GVariantBuilder directly on the
stack of the calling function and initialise it with
g_variant_builder_init()."
One of these leaks showed up in valgrind as:
==20702== 16,416 bytes in 114 blocks are definitely lost in loss record 2,114
of 2,115
==20702== at 0x4A0645D: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==20702== by 0x56EDDF2: g_malloc (gmem.c:97)
==20702== by 0x570691C: g_slice_alloc (gslice.c:1007)
==20702== by 0x5729743: g_variant_builder_new (gvariant.c:3169)
==20702== by 0x40297B: ibus_config_dconf_get_values (config.c:413)
==20702== by 0x4E44FF2: ibus_config_service_service_method_call
(ibusconfigservice.c:214)
==20702== by 0x4E33249: ibus_service_service_method_call_cb
(ibusservice.c:395)
==20702== by 0x51880D8: call_in_idle_cb (gdbusconnection.c:4875)
==20702== by 0x56E81D7: g_idle_dispatch (gmain.c:5319)
==20702== by 0x56E58F1: g_main_dispatch (gmain.c:3064)
==20702== by 0x56E6667: g_main_context_dispatch (gmain.c:3663)
==20702== by 0x56E6859: g_main_context_iterate (gmain.c:3734)
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/104850044
Patch from Christophe Fergeau <[email protected]>.
Commit: 0d153293b7a7a69796a61cd87832bbb583351778
https://github.com/ibus/ibus/commit/0d153293b7a7a69796a61cd87832bbb583351778
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M conf/dconf/config.c
Log Message:
-----------
dconf: Fix GVariant refcounting in watch_func()
IBusConfigDConf::watch_func() is roughly doing:
GVariant *variant = dconf_client_read(...)
if (variant == NULL) {
variant = g_variant_new(...);
}
ibus_config_service_value_changed(..., variant);
g_variant_unref(variant);
The problem with that is that the GVariant returned by
dconf_client_read() is non-floating while the one returned by
g_variant_new() is floating.
Since ibus_config_service_value_changed() will take ownership of
floating references, we should not unref 'variant' if it was created
through g_variant_new(), but we must call it when 'variant' is created
through dconf_client_read() or we will leak memory.
This commit fixes that by making sure we sink the reference we got
through g_variant_new().
This was sometimes causing crashes of ibus-dconf when repeatedly running
tests/ibus-config:
(ibus-dconf:24679): GLib-CRITICAL **: g_variant_unref: assertion
'value->ref_count > 0' failed
==24679== Invalid read of size 4
==24679== at 0x572E140: g_variant_unref (gvariant-core.c:625)
==24679== by 0x572DBB3: g_variant_release_children (gvariant-core.c:257)
==24679== by 0x572E202: g_variant_unref (gvariant-core.c:640)
==24679== by 0x572DBB3: g_variant_release_children (gvariant-core.c:257)
==24679== by 0x572E202: g_variant_unref (gvariant-core.c:640)
==24679== by 0x518CFDE: g_dbus_message_finalize (gdbusmessage.c:534)
==24679== by 0x5459628: g_object_unref (gobject.c:3112)
==24679== by 0x519C911: message_to_write_data_free (gdbusprivate.c:898)
==24679== by 0x519D687: write_message_cb (gdbusprivate.c:1353)
==24679== by 0x510F7F2: g_simple_async_result_complete
(gsimpleasyncresult.c:763)
==24679== by 0x519CEF2: write_message_continue_writing (gdbusprivate.c:1077)
==24679== by 0x519D040: write_message_async (gdbusprivate.c:1131)
==24679== Address 0x5d8c9c4 is 36 bytes inside a block of size 40 free'd
==24679== at 0x4A07577: free (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==24679== by 0x56EDF6B: g_free (gmem.c:190)
==24679== by 0x5706B53: g_slice_free1 (gslice.c:1112)
==24679== by 0x572E229: g_variant_unref (gvariant-core.c:643)
==24679== by 0x40240F: _watch_func (config.c:232)
==24679== by 0x3DEA605D8B: ffi_call_unix64 (in /usr/lib64/libffi.so.6.0.1)
==24679== by 0x3DEA6056BB: ffi_call (in /usr/lib64/libffi.so.6.0.1)
==24679== by 0x544EE88: g_cclosure_marshal_generic_va (gclosure.c:1541)
==24679== by 0x544D396: _g_closure_invoke_va (gclosure.c:831)
==24679== by 0x5468808: g_signal_emit_valist (gsignal.c:3215)
==24679== by 0x54699DF: g_signal_emit (gsignal.c:3363)
==24679== by 0x4C1478D: dconf_client_dispatch_change_signal
(dconf-client.c:150)
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/107800044
Patch from Christophe Fergeau <[email protected]>.
Commit: 167d1d7841eb5dd3957ceb72c4dcce784ea46456
https://github.com/ibus/ibus/commit/167d1d7841eb5dd3957ceb72c4dcce784ea46456
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M conf/gconf/config.c
Log Message:
-----------
Return non-floating ref from IBusConfigGConf::get_value
Both IBusConfigDConf::get_value and IBusConfigMemconf::get_value
return a non-floating reference, so we need to be consistent in the
gconf backend and also return a non-floating reference.
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/106830043
Patch from Christophe Fergeau <[email protected]>.
Commit: 5d887bde04d2fcfeb18437bbf675baf4a21e31e2
https://github.com/ibus/ibus/commit/5d887bde04d2fcfeb18437bbf675baf4a21e31e2
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M src/ibusconfigservice.c
Log Message:
-----------
Fix GVariant leak in IBusService::SetValue
When handling the DBus SetValue call,
ibusconfigservice.c:ibus_config_service_service_method_call()
gets a GVariant through g_variant_get("(&s&sv)")
GVariant documentation says that:
« Upon encountering a 'v', g_variant_get() takes a pointer to a
(GVariant *) (ie: (GVariant **) ). It is set to a new reference to a
GVariant instance containing the contents of the variant value. It is
appropriate to free this reference using g_variant_unref(). »
so we need to unreference it when we are done with it.
Running ibus-dconf in valgrind and then running tests/ibus-config
shows this leak:
==28085== 3,934 (1,520 direct, 2,414 indirect) bytes in 38 blocks are
definitely lost in loss record 2,112 of 2,121
==28085== at 0x4A0645D: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==28085== by 0x56EDDF2: g_malloc (gmem.c:97)
==28085== by 0x570691C: g_slice_alloc (gslice.c:1007)
==28085== by 0x572E6D9: g_variant_get_child_value (gvariant-core.c:1009)
==28085== by 0x57261C0: g_variant_get_variant (gvariant.c:715)
==28085== by 0x572BD03: g_variant_valist_get_nnp (gvariant.c:4794)
==28085== by 0x572C3F1: g_variant_valist_get_leaf (gvariant.c:4911)
==28085== by 0x572CAD4: g_variant_valist_get (gvariant.c:5092)
==28085== by 0x572CC59: g_variant_valist_get (gvariant.c:5127)
==28085== by 0x572D079: g_variant_get_va (gvariant.c:5354)
==28085== by 0x572CF9B: g_variant_get (gvariant.c:5301)
==28085== by 0x4E44E5B: ibus_config_service_service_method_call
(ibusconfigservice.c:173)
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/108740044
Patch from Christophe Fergeau <[email protected]>.
Commit: b07dedfb72eb65e4432efdd1348167db89c19639
https://github.com/ibus/ibus/commit/b07dedfb72eb65e4432efdd1348167db89c19639
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M src/ibusconfigservice.c
Log Message:
-----------
Fix GVariant leak in IBusService::GetValue
When handling the DBus GetValue call,
ibusconfigservice.c:ibus_config_service_service_method_call()
gets a non-floating GVariant reference through
IBusConfigService::get_value() but never unrefs it.
Running ibus-dconf in valgrind and then running tests/ibus-config
shows this leak:
=28085== 232 (80 direct, 152 indirect) bytes in 2 blocks are definitely lost in
loss record 2,025 of 2,121
==28085== at 0x4A0645D: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==28085== by 0x56EDDF2: g_malloc (gmem.c:97)
==28085== by 0x570691C: g_slice_alloc (gslice.c:1007)
==28085== by 0x572E6D9: g_variant_get_child_value (gvariant-core.c:1009)
==28085== by 0x57261C0: g_variant_get_variant (gvariant.c:715)
==28085== by 0x4C1A732: gvdb_table_value_from_item (gvdb-reader.c:578)
==28085== by 0x4C1A7A1: gvdb_table_get_value (gvdb-reader.c:610)
==28085== by 0x4C1589C: dconf_engine_read (dconf-engine.c:528)
==28085== by 0x4C14A79: dconf_client_read (dconf-client.c:242)
==28085== by 0x40286F: ibus_config_dconf_get_value (config.c:378)
==28085== by 0x4E44F29: ibus_config_service_service_method_call
(ibusconfigservice.c:194)
==28085== by 0x4E33249: ibus_service_service_method_call_cb
(ibusservice.c:395)
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/103100045
Patch from Christophe Fergeau <[email protected]>.
Commit: ee4c5ec0a39b5ed4a22fe34307a44f3f9fa1303b
https://github.com/ibus/ibus/commit/ee4c5ec0a39b5ed4a22fe34307a44f3f9fa1303b
Author: fujiwarat <[email protected]>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M bus/ibusimpl.c
M engine/simple.xml.in
Log Message:
-----------
Add Polish (qwertz) keymap in simple.xml
BUG=http://code.google.com/p/ibus/issues/detail?id=1716
TEST=ibus-setup
Review URL: https://codereview.appspot.com/102150045
Commit: 6291feb259cee5589683cf7ac1a87c44582ba3c0
https://github.com/ibus/ibus/commit/6291feb259cee5589683cf7ac1a87c44582ba3c0
Author: Christophe Fergeau <[email protected]>
Date: 2014-06-09 (Mon, 09 Jun 2014)
Changed paths:
M src/tests/ibus-config.c
Log Message:
-----------
tests/ibus-config Fix timeout_id handling
tests/ibus-config queues a timeout whose callback calls
g_main_loop_quit() before returning FALSE. After exiting the mainloop,
g_source_remove(timeout_id) is called, but if the mainloop was exited
through the timeout callback, the source will already have been removed.
This commit makes sure we only try to call g_source_remove() on that
timeout if we did not exit the mainloop through the timeout callback.
BUG=http://code.google.com/p/ibus/issues/detail?id=1712
Review URL: https://codereview.appspot.com/108730044
Patch from Christophe Fergeau <[email protected]>.
Commit: e46502f1d3a8c69e6e473cdb35e790e565d89705
https://github.com/ibus/ibus/commit/e46502f1d3a8c69e6e473cdb35e790e565d89705
Author: fujiwarat <[email protected]>
Date: 2014-06-10 (Tue, 10 Jun 2014)
Changed paths:
M src/ibusinputcontext.c
Log Message:
-----------
Fix a typo in src/ibusinputcontext.c
BUG=http://code.google.com/p/ibus/issues/detail?id=1717
Review URL: https://codereview.appspot.com/107860043
Commit: 9bad0c944162a1700dcb6615aab2a6a9cfd9eff5
https://github.com/ibus/ibus/commit/9bad0c944162a1700dcb6615aab2a6a9cfd9eff5
Author: fujiwarat <[email protected]>
Date: 2014-06-12 (Thu, 12 Jun 2014)
Changed paths:
M src/ibusenginesimple.c
Log Message:
-----------
Fix escape key with Ctrl+Shift+U ISO 14755.
GtkIMContextSimple uses gdk_keymap_get_for_display() to check the readable
hex codes but IBusEngineSimple ignored it because does not have the display
argument.
I added is_hex_keyval() to check the escape key and fix this bug.
BUG=http://code.google.com/p/ibus/issues/detail?id=1715
TEST=src/libibus.so
Review URL: https://codereview.appspot.com/101160044
Commit: b6afffbd1a06ecf17af009f1de3e513988ecb92e
https://github.com/ibus/ibus/commit/b6afffbd1a06ecf17af009f1de3e513988ecb92e
Author: fujiwarat <[email protected]>
Date: 2014-06-18 (Wed, 18 Jun 2014)
Changed paths:
M src/gencomposetable.c
M src/ibuscomposetable.h
Log Message:
-----------
Update ibuscomposetable.h for pt-br.
pt_BR.UTF-8/Compose file is updated:
http://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=e3dc0d1733
TEST=engine/test-compose on pt_BR.UTF-8
Review URL: https://codereview.appspot.com/101330044
Commit: 38fa3e8a57262e4d76afe9bc348d14cc37af5cfc
https://github.com/ibus/ibus/commit/38fa3e8a57262e4d76afe9bc348d14cc37af5cfc
Author: fujiwarat <[email protected]>
Date: 2014-06-23 (Mon, 23 Jun 2014)
Changed paths:
M data/ibus.schemas.in
M ui/gtk3/Makefile.am
M ui/gtk3/panel.vala
A ui/gtk3/xkblayout.vala
Log Message:
-----------
Set up ibus engines when users log into the session for the first time.
XKB engines are configured by the session XKB.
IM engines are configured by the current locale and IBusEngineDesc.lang.
Also append 'us' layout after non-ascii layout likes 'ara', 'ru'.
BUG=rhbz#541492
TEST=ui/gtk3/ibus-ui-gtk3 data/dconf/org.freedesktop.ibus.gschema.xml
Review URL: https://codereview.appspot.com/103440043
Commit: a5300750e38b5327bdd255d777544d0c0ebcb4d9
https://github.com/ibus/ibus/commit/a5300750e38b5327bdd255d777544d0c0ebcb4d9
Author: fujiwarat <[email protected]>
Date: 2014-06-24 (Tue, 24 Jun 2014)
Changed paths:
M setup/enginetreeview.py
M setup/main.py
Log Message:
-----------
Do not sort ibus engines when they are saved by ibus-setup.
ibus 1.5 changes the engine order with Super+space shortcut key
and now ibus-setup shows the sorted engines by longname on UI.
This fixes not to save the sorted order with ibus-setup.
TEST=setup
Review URL: https://codereview.appspot.com/102610044
Commit: 8ef258ec31f12405e4f5ded6a7a4d80114a219d4
https://github.com/ibus/ibus/commit/8ef258ec31f12405e4f5ded6a7a4d80114a219d4
Author: Osamu Aoki <[email protected]>
Date: 2014-07-03 (Thu, 03 Jul 2014)
Changed paths:
M data/keymaps/jp
Log Message:
-----------
Use "keycode Linux_keycode = X11_keysym" format
Delete non-Linux keyboard compatibility.
These are tested for both PC and Mac. Using showkey and xev
Notably:
Hangul = Eisuu-on-mac-keyboard
Hangul_Hanja = Kana/kana -on-mac-keyboard
BUG=http://code.google.com/p/ibus/issues/detail?id=1724
TEST=data/keymaps/keycode.py
Review URL: https://codereview.appspot.com/106250045
Patch from Osamu Aoki <[email protected]>.
Commit: 14bd9381127e692b944eb31f56a2cc5b9de2e7a1
https://github.com/ibus/ibus/commit/14bd9381127e692b944eb31f56a2cc5b9de2e7a1
Author: fujiwarat <[email protected]>
Date: 2014-07-04 (Fri, 04 Jul 2014)
Changed paths:
M data/ibus.schemas.in
M ui/gtk3/panel.vala
M ui/gtk3/xkblayout.vala
Log Message:
-----------
Run xmodmap after run setxkbmap -l layout.
BUG=rhbz#750484
TEST=ui/gtk3/ibus-ui-gtk3 data/dconf/org.freedesktop.ibus.gschema.xml
Review URL: https://codereview.appspot.com/101490043
Commit: 3dcf24742216d6234a45ace1b433b864efdf08a2
https://github.com/ibus/ibus/commit/3dcf24742216d6234a45ace1b433b864efdf08a2
Author: fujiwarat <[email protected]>
Date: 2014-07-04 (Fri, 04 Jul 2014)
Changed paths:
M tools/main.vala
Log Message:
-----------
Add ibus reset-config and read-config sub-commands.
BUG=rhbz#530711
TEST=tools/ibus
Review URL: https://codereview.appspot.com/103670044
Commit: 9e5a2bd2c40f9eed8d99710b63b3dab737aa9b95
https://github.com/ibus/ibus/commit/9e5a2bd2c40f9eed8d99710b63b3dab737aa9b95
Author: fujiwarat <[email protected]>
Date: 2014-07-08 (Tue, 08 Jul 2014)
Changed paths:
M tools/ibus.1.in
Log Message:
-----------
Update ibus(1) for read-config and reset-config.
TEST=tools/ibus.1.gz
Review URL: https://codereview.appspot.com/111900044
Commit: 10483bfebd1f51ffa52ad7d017193ae728f93bf5
https://github.com/ibus/ibus/commit/10483bfebd1f51ffa52ad7d017193ae728f93bf5
Author: fujiwarat <[email protected]>
Date: 2014-07-10 (Thu, 10 Jul 2014)
Changed paths:
M setup/enginetreeview.py
Log Message:
-----------
Fix ibus-setup SEGV in enginetreeview.py
When an engine is added on ibus-setup, enginetreeview.append_engine()
calls self.__model.append(None) and it causes engine == None in
__icon_cell_data_cb() and __name_cell_data_cb() in enginetreeview
with python3-gobject 3.13.x which version has implemented several
deprecated warnings in gi/overrides/Gtk.py .
I think this problem also could happen in the old versions if
the system would be slow.
BUG=rhbz#1048429
TEST=setup in Fedora 21
Review URL: https://codereview.appspot.com/104620043
Commit: a17dc8e8bd288adedb77ae417d6825419337daae
https://github.com/ibus/ibus/commit/a17dc8e8bd288adedb77ae417d6825419337daae
Author: fujiwarat <[email protected]>
Date: 2014-07-11 (Fri, 11 Jul 2014)
Changed paths:
M setup/engineabout.py
M setup/keyboardshortcut.py
M setup/main.py
M setup/setup.ui
Log Message:
-----------
Fix deprecated warnings with python3-gobject 3.13.3.
python3-gobject adds several warnings in gi/overrides/Gtk.py
/usr/share/ibus/setup/main.py:74: PyGIDeprecationWarning:
Using positional arguments with the GObject constructor has been
deprecated. Please specify keyword(s) for "schema" or use a class
specific constructor.
See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
/usr/share/ibus/setup/main.py:364: PyGTKDeprecationWarning:
The keyword(s) "type" have been deprecated in favor of "message_type"
respectively.
See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
TEST=setup
Review URL: https://codereview.appspot.com/110990044
Commit: b1b4e2946682e3d53aa396d8469c7fa16a2dbca8
https://github.com/ibus/ibus/commit/b1b4e2946682e3d53aa396d8469c7fa16a2dbca8
Author: fujiwarat <[email protected]>
Date: 2014-07-11 (Fri, 11 Jul 2014)
Changed paths:
M setup/main.py
Log Message:
-----------
Export the 'IBUS_SETUP_XID' environment variable for each engine setup.
Follow GNOME_CONTROL_CENTER_XID.
https://wiki.gnome.org/AllanDay/IMEGuidelines
TEST=setup
Review URL: https://codereview.appspot.com/112920044
Commit: 9b2004efcd26e11bbd56cf51656fe326fc11be8e
https://github.com/ibus/ibus/commit/9b2004efcd26e11bbd56cf51656fe326fc11be8e
Author: fujiwarat <[email protected]>
Date: 2014-07-14 (Mon, 14 Jul 2014)
Changed paths:
M setup/main.py
Log Message:
-----------
Call GLib.set_prgname('ibus-setup') for ibus-setup main.py
TEST=xlsclients
Review URL: https://codereview.appspot.com/108550043
Commit: 47a6b86f197918147693a7b4774d02a287950e6a
https://github.com/ibus/ibus/commit/47a6b86f197918147693a7b4774d02a287950e6a
Author: fujiwarat <[email protected]>
Date: 2014-07-14 (Mon, 14 Jul 2014)
Changed paths:
M po/es.po
M po/fr.po
M po/ja.po
M po/ko.po
M po/pl.po
M po/pt_BR.po
M po/uk.po
M po/zh_TW.po
Log Message:
-----------
Update translations.
Update es.po fr.po ja.po ko.po pl.po pt_BR.po uk.po zh_TW.po
Review URL: https://codereview.appspot.com/108480043
Commit: 130d3108902ed3e7c61930e3a24ee957c3d3e658
https://github.com/ibus/ibus/commit/130d3108902ed3e7c61930e3a24ee957c3d3e658
Author: fujiwarat <[email protected]>
Date: 2014-07-17 (Thu, 17 Jul 2014)
Changed paths:
M ui/gtk3/candidatearea.vala
M ui/gtk3/candidatepanel.vala
M ui/gtk3/keybindingmanager.vala
M ui/gtk3/propertypanel.vala
M ui/gtk3/switcher.vala
Log Message:
-----------
Fix deprecated gtk3 GtkMisc, GtkAlignment and vala Gdk.X11Display
gtk 3.13.4 warns GtkMisc and GtkAlignment
vala 0.24 warns Gdk.X11Display
https://git.gnome.org/browse/gtk+/commit/?id=ec0a60a248
https://git.gnome.org/browse/gtk+/commit/?id=04703689b8
https://git.gnome.org/browse/vala/commit/?id=b65e3dc87c
TEST=make ui/gtk3
Review URL: https://codereview.appspot.com/114820044
Commit: 3e6178c04869cceba3e5d681c9827ab54098f3b4
https://github.com/ibus/ibus/commit/3e6178c04869cceba3e5d681c9827ab54098f3b4
Author: fujiwarat <[email protected]>
Date: 2014-07-18 (Fri, 18 Jul 2014)
Changed paths:
M po/POTFILES.in
M setup/Makefile.am
A setup/enginedialog.py
M setup/enginetreeview.py
M setup/main.py
Log Message:
-----------
Enhance UI to add engines on ibus-setup
BUG=rhbz#803583
TEST=setup
Review URL: https://codereview.appspot.com/118830043
Commit: 54e01d4343766467269e0d0cb8b6f208bbb35c4c
https://github.com/ibus/ibus/commit/54e01d4343766467269e0d0cb8b6f208bbb35c4c
Author: fujiwarat <[email protected]>
Date: 2014-07-24 (Thu, 24 Jul 2014)
Changed paths:
M po/ja.po
Log Message:
-----------
Update translations.
Update ja.po
Review URL: https://codereview.appspot.com/118890043
Commit: 78dfe648c736d62921c77f2de931898762409b0e
https://github.com/ibus/ibus/commit/78dfe648c736d62921c77f2de931898762409b0e
Author: fujiwarat <[email protected]>
Date: 2014-07-24 (Thu, 24 Jul 2014)
Changed paths:
M configure.ac
Log Message:
-----------
Release 1.5.8
Review URL: https://codereview.appspot.com/113280043
Compare: https://github.com/ibus/ibus/compare/15126830212f...78dfe648c736
--
--
You received this message because you are subscribed to the Google
Groups "ibus-devel" group.
iBus project web page: http://code.google.com/p/ibus/
iBus dev group: http://groups.google.com/group/ibus-devel?hl=en
---
You received this message because you are subscribed to the Google Groups
"ibus-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
