Re: [Ilohamail-devel] Bug with forwarding attachements (need help with testing and coding) ( RESOLVED )

[Ondra Kudlik]

So after some time I found that problem is at two places. First and
critical is in compose_package.inc where is fetched encoded
attachement and crippled while saving to temp location.

I correct this bug and attach the patch. Please, test it.

Second one is in reading this crippled attachement, other clients
which I tried can do this but I'm not able to found where the
problem is. I write where is source of problem in original post.

Thu, Oct 27, 2005 ve 04:11:05PM +0200, Ondra Kudlik napsal:
> Ok, thanks for confirment. For myself, i cannot noticed it before
> because I'm not really active user of iloha :) I like mutt :)
> 
> So if anybody have a time, please tak a look, I'm _almost_ 100 % sure
> that problem is in include/imap.inc, it takes me a lot of time to
> eleminate other possibilities... 
> 
> My problem is that i'm not familiar with imap protocol, so it will
> take me more time and as I said, I'm not able too work on it sooner
> than two days...
> 
> Thu, Oct 27, 2005 ve 02:46:45PM +0200, Martin Waschbüsch napsal:
> > I just tested it and I seem to have the same problem. I also use the
> > devel version.
> > 
> > Strange thing is I have not noticed it before...
> > 
> > Martin
> > 
> > Am 26.10.2005 schrieb "Ondra Kudlik" <[EMAIL PROTECTED]>:
> > >> .....
> > >> 
> > >> I correct this one by modify include/imap.inc on line 1811 line
> > >>
> > >> return substr($result, 0, strlen($result)-1);
> > >>
> > >> with
> > >>
> > >> return $result;

Now I can see that is really bad that no changelog from cvs are sent
to devel list because my work was useless :( Ryo correct probelm
with cutting last character two weeks ago in cvs

-- 
 .''`. Ondra 'Kepi' Kudlik
: :' : Debian GNU/Linux User
`. `'
  `-   http://www.nosoftwarepatents.com/cz/m/intro/index.html 


--- include/compose_package.inc 2005-10-29 20:51:42.000000000 +0200
+++ include/compose_package.inc.new     2005-10-29 20:53:37.000000000 +0200
@@ -100,8 +100,8 @@
                        if ($part[$i]["encoded"]){
                                //straight transfer if already encoded
                                while(!feof($ul_fp)){
-                                       $line = chop(fgets($ul_fp, 5000));
-                                       fputs($temp_fp, $line)."\r\n";
+                                       $line = fgets($ul_fp, 5000);
+                                       fputs($temp_fp, $line);
                                }
                        }else{
                                //otherwisee, base64 encode

signature.asc
Description: Digital signature