On Jun 30, "H. Turgut Uyar" <[EMAIL PROTECTED]> wrote: > I'm just confused about how to run it and how to activate the DOM > parsers. The code refers to an imdbdom package as in: > from imdbdom.utils import ...
Aaargh! My fault - there is no "imdbdom": at one time I just introduced it to do some tests on my system, without messing with the "normal" 'imdb' package. I'll removed it from the CVS right now - just replacing every "imdbdom" with "imdb". > I agree with "elem" not being a nice name :-) At one time I had > thought of naming it as "foreach" (to read it like "foreach td/a do > the attribute paths are..."), then it sounded a bit too mechanical. I can't think about any good name. :-) "elements" is a bit too long; maybe "nodes"? Or is it misleading? > You've introduced back the analyze_imdbid function which I had > removed and used simple slicing instead. My reason for removing it > was to prevent incorrect matches like matching a person id when we > are trying to get a movie id. I didn't thought of this case, you're right. To tell the truth in many situations the old parsers used a regexp very similar to your, and I've never hit any problem, but... > But this comes from the simple regex I've written and it could be > corrected by making analyze_imdbid smarter. It's probabily a good idea (but not a top priority). I'm more concerned about error handling: there are so many cases where things can go bad, e.g.: feeding a movie page to the movie search parser; it can happen if we have a direct match, but so far the parser just _explodes_. ;-) > I'm concerned about the performance and memory usage issues, So far, I had a nice impression, but I made no benchmarks. In the next days, I'll try to collect title/names references and maybe I'll write a parser or two. PS: to receive mail notifications of CVS commits, there is a mailing list, that can be subscribed here: https://lists.sourceforge.net/lists/listinfo/imdbpy-cvs Thanks! -- Davide Alberani <[EMAIL PROTECTED]> [PGP KeyID: 0x465BFD47] http://erlug.linux.it/~da/ ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Imdbpy-devel mailing list Imdbpy-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/imdbpy-devel
