On Jul 01, "H. Turgut Uyar" <[EMAIL PROTECTED]> wrote: > I've noticed a problem here when working with the search movie > parser: The method that calls the parser expects the result to be > a dictionary which has a 'data' key that contains a list of tuples
This - and the other problems - were mine faults: I forgot to check the exact API and I only made "direct" tests of the parsers, without using them in a real environment, so your patches are correct, thanks! > I've committed a patch which implements the first method but the > second method would probably be better. Can you take a look at it? In my opinion the "postprocess_data" method should be used only as a last resort, where it's not possible/easy to build the expected data structure using "parse_dom". So, your solution is fine, but consider that actually the other search* parsers are subclasses of DOMHTMLSearchMovieParser; if it's possible to return also the other search results using only "parse_dom" ok, otherwise let's use "postprocess_data" for all of these parsers. -- Davide Alberani <[EMAIL PROTECTED]> [PGP KeyID: 0x465BFD47] http://erlug.linux.it/~da/ ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ Imdbpy-devel mailing list Imdbpy-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/imdbpy-devel
