On Apr 25, 2013, at 1:37 PM, Manik Surtani <[email protected]> wrote:
> > On 25 Apr 2013, at 11:41, Galder Zamarreño <[email protected]> wrote: > >> So, in case anyone is itching to start on 3022 and 3023, hold on for a few >> days while I finish the work to include EquivalentCHMv8. > > 3022 is already in. The patch was trivial - change a default value in > ConcurrentMapFactory. Once you finish EquivalentCHMv8, again, all you need > to do is change ConcurrentMapFactory again to use EquivalentCHMv8 instead of > CHMv8. ^ Ok, I'll have to rebase that. Btw, something coming up in the 2281 pull req: I'm changing ConcurrentMapFactory to be CollectionFactory to deal with other collections to be able to return normal hash maps or equivalent hash maps too, because once you allow a array based key, any collection that has a reference to a key (i.e. invocation context), must keep this in a equivalent collection too. > > As a side point, as you implement EquivalentCHMv8, could you make sure it is > based on the latest CHMv8 impl from jsr166e: > > http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/jsr166e/ConcurrentHashMapV8.java?revision=1.100&view=markup > > We should also include, in the comments, what revision of jsr166e's > implementation we're based on (e.g., 1.100 in the link above). Great minds think alike :) https://github.com/galderz/infinispan/blob/t_2281/core/src/main/java/org/infinispan/util/concurrent/jdk8backported/EquivalentConcurrentHashMapV8.java#L24 > > - M > > -- > Manik Surtani > [email protected] > twitter.com/maniksurtani > > Platform Architect, JBoss Data Grid > http://red.ht/data-grid > > > _______________________________________________ > infinispan-dev mailing list > [email protected] > https://lists.jboss.org/mailman/listinfo/infinispan-dev -- Galder Zamarreño [email protected] twitter.com/galderz Project Lead, Escalante http://escalante.io Engineer, Infinispan http://infinispan.org _______________________________________________ infinispan-dev mailing list [email protected] https://lists.jboss.org/mailman/listinfo/infinispan-dev
