Dimitrie O. Paun writes:
>
> 1. What is the CVS dir used for on the server
Storing various extra per-directory information. Currently, the only
thing stored there is the fileattr file that records information about
watches and editors.
> 2. Any (bad) side effects of the fact that we've removed a few
You lose the watch/editor info. (Which can be either bad or good,
depending on your viewpoint!)
> 3. Can I delete all fileattr files to clean up the repository? I've tried
> unwatch a number of time, but it does not work!!!
Sure. In fact, that seems to be the problem -- it would appear that you
have bogus entries in some of the fileattr files and the code to deal
with that is buggy.
> Excellent. Do you have any idea when cvs 1.10.9 is going to be released? I
> also contains the file handle leak fix as well...
Nope, that's up to OpenAvenue. There have been lots of bug fixes
checked in since 1.10.8, so I'd say we're due for a new interim release
just as soon as someone at OpenAvenue can figure out how to make one.
Here's a patch for the fileattr crash problem:
Index: fileattr.c
===================================================================
RCS file: /home2/cvsroot/ccvs/src/fileattr.c,v
retrieving revision 1.18
diff -u -r1.18 fileattr.c
--- fileattr.c 2000/06/16 18:34:52 1.18
+++ fileattr.c 2000/07/06 15:25:15
@@ -513,6 +513,7 @@
FILE *fp;
char *fname;
mode_t omask;
+ struct unrecog *p;
if (!attrs_modified)
return;
@@ -616,17 +617,10 @@
}
/* Then any other attributes. */
- while (unrecog_head != NULL)
+ for (p = unrecog_head; p != NULL; p = p->next)
{
- struct unrecog *p;
-
- p = unrecog_head;
fputs (p->line, fp);
fputs ("\012", fp);
-
- unrecog_head = p->next;
- free (p->line);
- free (p);
}
if (fclose (fp) < 0)
@@ -649,4 +643,11 @@
if (fileattr_default_attrs != NULL)
free (fileattr_default_attrs);
fileattr_default_attrs = NULL;
+ while (unrecog_head)
+ {
+ struct unrecog *p = unrecog_head;
+ unrecog_head = p->next;
+ free (p->line);
+ free (p);
+ }
}
-Larry Jones
I think football is a sport the way ducks think hunting is a sport. -- Calvin
