Guus Leeuw writes:
> 
> Found sofar a good place to get the server's
> $CVSROOT/CVSROOT/cvsignore: start_server() in client.c right after
> we do connect_to_?server().

I'm not sure that's safe -- I suspect that it's better to do it in
ign_setup() right where it processes CVSROOT/cvsignore in the local
case.  Although the current CVS client never does more than one command
per connection, that isn't officially part of the protocol and I believe
there are other clients that do use multiple commands and thus call
ign_setup() multiple times.  Of course, that means that you can't call
ign_setup() until after you've done start_server(), which probably
involves lots of changes to the individual commands (since there's no
easy way out once you've call start_server()); but you'd have to do that
in either case since it wouldn't be much good to get CVSROOT/cvsignore
after you'd called ign_setup().

> One thing though, Larry (*grin*), and that is:
> what about :ext: protocols where to user is supposed to have a
> login on the server?
> If the server now only sends the Repository's cvsignore, whatever
> the user has setup in his $HOME/.cvsignore will not be send to the
> client. Is this wanted? Or should I rather go and make only changes
> for GSSAPI, KERBEROS, and PSERVER?

I think ~/.cvsignore on the server should be ignored.

-Larry Jones

They say winning isn't everything, and I've decided
to take their word for it. -- Calvin

Reply via email to