On 23/10/02 13:13 +1000, Sisyphus wrote:
> 
> ----- Original Message -----
> From: "Brian Ingerson" <[EMAIL PROTECTED]>
> To: "Sisyphus" <[EMAIL PROTECTED]>
> Cc: "Inline Mailing List" <[EMAIL PROTECTED]>
> Sent: Wednesday, October 23, 2002 11:04 AM
> Subject: Re: Hmmm:Inline-0.44/Inline::C v5.6.1 - solved ?
> 
> 
> > On 23/10/02 09:37 +1000, Sisyphus wrote:
> > > Ok ... my problem vanishes if I do the following:
> > >
> > >     $realname =~ s/\\/\//; # change '\' to '/'
> > >      # a few lines further on:
> > >       $realname =~ s/\//\\/g; #change '/' to '\'
> > >     File::Spec->catfile(@endparts) eq $realname
> > >       or croak M28_error_grokking_path($realpath);
> >
> > Great. Could you send me a patch file. Just run (using cygwin):
> >
> >     diff -u Inline.pm.orig Inline.pm.fixed > patch
> >
> 
> That could take a while ... I think I have the patch utility here somewhere,
> but I've never used it, and have never written a patch.

You don't actually *write* a patch. You just copy the original file, fix
the copy, test it, and run the above diff command. A patch is just the
output of diff. It's more simple than simple.

    cp Inline.pm Inline.pm.orig
    vim Inline.pm   # make changes
    make test       # or whatever testing needs to be done
    diff -u Inline.pm.orig Inline.pm > patch   # creates file called 'patch'
    # Mail patch to [EMAIL PROTECTED]
    

> 
> Basically we can insert '$realname =~ s/\\/\//g;' immediately above
>     'my $realpath = $INC{$realname}
>        or croak M27_module_not_indexed($realname);'
> 
> and insert '$realname =~ s/\//\\/g;' immediately above
> '     File::Spec->catfile(@endparts) eq $realname
>        or croak M28_error_grokking_path($realpath);'
> 
> and the problem goes away. Is there a need to put both of those insertions
> inside a 'if ($^O eq "MSWin32"){}' block ? I guess not.

This will fix the problem on MSWin32. Not on MacOS. VMS? Amiga? Plan9?
BeOS? Don't know.

I'm tempted to just apply the Windowsy patch for now. I can fix it better
later. At least we wouldn't *lose* compatability.

> 
> There's still a weird little problem that I've just uncovered when I try to
> build my module (source in a separate file).
> 
> Seems to proceed ok until I run 'nmake test' , at which point only one of
> the functions in @Export can be found - and I can't work out why it's that
> specific function (as opposed to any other function) that can be found.
> 
....

> I'll try and work out what's happening tonight if I get a chance.

Please do. I'm not sure I understand the exact problem you are having. Please
try to recreate it with Math::Simple, if possible.

Cheers, Brian

Reply via email to