On 24/10/02 05:30 +1000, Sisyphus wrote:
> 
> ----- Original Message -----
> From: "Brian Ingerson" <[EMAIL PROTECTED]>
> To: "Sisyphus" <[EMAIL PROTECTED]>
> Cc: "Inline Mailing List" <[EMAIL PROTECTED]>
> Sent: Wednesday, October 23, 2002 5:00 PM
> Subject: Re: Hmmm:Inline-0.44/Inline::C v5.6.1 - solved ?
> 
> 
> > On 23/10/02 13:13 +1000, Sisyphus wrote:
> > >
> > > ----- Original Message -----
> > > From: "Brian Ingerson" <[EMAIL PROTECTED]>
> > > To: "Sisyphus" <[EMAIL PROTECTED]>
> > > Cc: "Inline Mailing List" <[EMAIL PROTECTED]>
> > > Sent: Wednesday, October 23, 2002 11:04 AM
> > > Subject: Re: Hmmm:Inline-0.44/Inline::C v5.6.1 - solved ?
> > >
> > >
> > > > On 23/10/02 09:37 +1000, Sisyphus wrote:
> > > > > Ok ... my problem vanishes if I do the following:
> > > > >
> > > > >     $realname =~ s/\\/\//; # change '\' to '/'
> > > > >      # a few lines further on:
> > > > >       $realname =~ s/\//\\/g; #change '/' to '\'
> > > > >     File::Spec->catfile(@endparts) eq $realname
> > > > >       or croak M28_error_grokking_path($realpath);
> > > >
> > > > Great. Could you send me a patch file. Just run (using cygwin):
> > > >
> > > >     diff -u Inline.pm.orig Inline.pm.fixed > patch
> > > >
> > >
> > > That could take a while ... I think I have the patch utility here
> somewhere,
> > > but I've never used it, and have never written a patch.
> > >
> > > Basically we can insert '$realname =~ s/\\/\//g;' immediately above
> > >     'my $realpath = $INC{$realname}
> > >        or croak M27_module_not_indexed($realname);'
> > >
> > > and insert '$realname =~ s/\//\\/g;' immediately above
> > > '     File::Spec->catfile(@endparts) eq $realname
> > >        or croak M28_error_grokking_path($realpath);'
> >
> > Upon closer inspection, your patch seems not to make sense. Why the second
> > substitution? $realname is not changed between substitutions. I'm guessing
> > you were fooled into doing this because you forgot the 'g' modifier on the
> > first substitution.

Upon even closer inspection, it was me who was not making sense. I'll give
this another go in the morning. :)

Cheers, Brian

Reply via email to