Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: Odd issue with pod2man when building on Fedora build
server (Jochen Schmitt)
2. Re: Odd issue with pod2man when building on Fedora build
server (Russ Allbery)
----------------------------------------------------------------------
Message: 1
Date: Tue, 28 May 2013 18:38:19 +0200
From: Jochen Schmitt <[email protected]>
To: Julien ?LIE <[email protected]>
Cc: [email protected]
Subject: Re: Odd issue with pod2man when building on Fedora build
server
Message-ID: <[email protected]>
Content-Type: text/plain; charset=iso-8859-1
On Mon, May 27, 2013 at 07:50:12PM +0200, Julien ?LIE wrote:
> Hi Russ,
> Besides, the patch for Fedora does not currently work because of
> typos in the names: MADV_SEQUENTAL, POSIX_MADV_SEQENTIAL,
> MADV_SEQUITIAL.
Thank you for this information. I have tried to fix the typos.
It may be nice, if you can review the attached patch.
Best Regards:
Jochen Schmitt
diff -up inn-2.5.2/storage/cnfs/cnfs.h.posix inn-2.5.2/storage/cnfs/cnfs.h
--- inn-2.5.2/storage/cnfs/cnfs.h.posix 2010-03-24 21:10:36.000000000 +0100
+++ inn-2.5.2/storage/cnfs/cnfs.h 2010-06-28 17:33:11.106804964 +0200
@@ -18,4 +18,12 @@ void cnfs_printfiles(FILE *file, TOKEN t
char *cnfs_explaintoken(const TOKEN token);
void cnfs_shutdown(void);
+/* Patch for POSIX */
+
+#ifndef MADV_SEQUENTAL
+ #ifdef POSIX_MADV_SEQUENTIAL
+ #define MADV_SEQUENTIAL POSIX_MADV_SEQUENTIAL
+ #endif
+#endif
+
#endif
------------------------------
Message: 2
Date: Tue, 28 May 2013 10:34:23 -0700
From: Russ Allbery <[email protected]>
To: [email protected]
Subject: Re: Odd issue with pod2man when building on Fedora build
server
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Jochen Schmitt <[email protected]> writes:
> Thank you for this information. I have tried to fix the typos.
> It may be nice, if you can review the attached patch.
I think you should just drop this patch completely. It had never done
anything (due to the typos), and I don't see any motivation for it.
I don't believe it's formally correct to pass POSIX_* constants into the
madvise() (as opposed to posix_madvise()) function. There's no guarantee
that they will have the same numeric values.
--
Russ Allbery ([email protected]) <http://www.eyrie.org/~eagle/>
Please send questions to the list rather than mailing me directly.
<http://www.eyrie.org/~eagle/faqs/questions.html> explains why.
------------------------------
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
End of inn-workers Digest, Vol 51, Issue 8
******************************************
