Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Unexpected rejection of path element in inn-2.5.3.
(Jochen Schmitt)
2. Re: Unexpected rejection of path element in inn-2.5.3.
(Florian Schlichting)
3. Re: [PATCH] innfeed does not reopen (rotated) log file
(Julien ?LIE)
4. Re: [PATCH] innfeed does not reopen (rotated) log file
(Florian Schlichting)
----------------------------------------------------------------------
Message: 1
Date: Thu, 30 May 2013 21:05:20 +0200
From: Jochen Schmitt <[email protected]>
To: [email protected]
Subject: Unexpected rejection of path element in inn-2.5.3.
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Hallo,
I have got an issue with inn-2.5.3 during fedding it with new articles
from another news server via suck.
I have got the following error messages:
340 Ok, recommended ID <[email protected]>
441 Path contains invalid element "fu-berlin.de".
Malfunction, Unable to post Article!
441 Path contains invalid element "fu-berlin.de".
340 Ok, recommended ID <[email protected]>
441 Foreign supersedes - You have no permission to supersede
<[email protected]>
Malfunction, Unable to post Article!
441 Foreign supersedes - You have no permission to supersede
<[email protected]>
340 Ok, recommended ID <[email protected]>
441 Path contains invalid element "fu-berlin.de".
Malfunction, Unable to post Article!
441 Path contains invalid element "fu-berlin.de".
340 Ok, recommended ID <[email protected]>
441 Path contains invalid element "fu-berlin.de".
Malfunction, Unable to post Article!
441 Path contains invalid element "fu-berlin.de".
It may be nice, if anyone has a explaination for this effect.
Best Regards:
Jochen Schmitt
------------------------------
Message: 2
Date: Thu, 30 May 2013 21:44:28 +0200
From: Florian Schlichting <[email protected]>
To: Jochen Schmitt <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: Unexpected rejection of path element in inn-2.5.3.
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"
Hi Jochen,
> I have got an issue with inn-2.5.3 during fedding it with new articles
> from another news server via suck.
it is not inn-2.5.3 you are talking to
> I have got the following error messages:
>
>
> 340 Ok, recommended ID <[email protected]>
> 441 Path contains invalid element "fu-berlin.de".
> Malfunction, Unable to post Article!
> 441 Path contains invalid element "fu-berlin.de".
> 340 Ok, recommended ID <[email protected]>
> 441 Foreign supersedes - You have no permission to supersede
> <[email protected]>
> Malfunction, Unable to post Article!
> 441 Foreign supersedes - You have no permission to supersede
> <[email protected]>
> 340 Ok, recommended ID <[email protected]>
> 441 Path contains invalid element "fu-berlin.de".
> Malfunction, Unable to post Article!
> 441 Path contains invalid element "fu-berlin.de".
> 340 Ok, recommended ID <[email protected]>
> 441 Path contains invalid element "fu-berlin.de".
> Malfunction, Unable to post Article!
> 441 Path contains invalid element "fu-berlin.de".
>
> It may be nice, if anyone has a explaination for this effect.
This is not your news server you are talking to, but ours.
News.Individual.NET does not accept articles with a Path header that
contains "fu-berlin.de". And we don't allow you to post supersedes for
anything else than your own articles either.
Just out of curiosity, what did you do with the other ten articles? Your
script downloaded 97 but only tried to post 87 articles... we want them
all back, you know ;-)
Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5565 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20130530/93496497/attachment-0001.bin>
------------------------------
Message: 3
Date: Thu, 30 May 2013 22:08:07 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: [PATCH] innfeed does not reopen (rotated) log file
Message-ID: <[email protected]>
Content-Type: text/plain; charset=ISO-8859-1
Hi Florian,
> Subject: [PATCH] innfeed, scanlogs: reopen log files on sighup
Don't worry; I have been trying different variations of your kind patch for a
few days. (Thanks for having also attached an update for the documentation!)
> --- a/scripts/scanlogs.in
> +++ b/scripts/scanlogs.in
> @@ -169,6 +184,15 @@ if ${ROTATE} ; then
> rm -f ${LOCK}
> exit 1
> fi
> + if [ ! -z $INNFEEDPID ]; then
> + OUTPUT=`kill -HUP $INNFEEDPID 2>&1`
> + if [ "x$OUTPUT" != "x" ]; then
> + echo "$OUTPUT"
> + echo 'Cannot flush innfeed logs.'
> + rm -f ${LOCK}
> + exit 1
> + fi
> + fi
>
> ${PAUSED} && ctlinnd -s go "Flushing log and syslog files" 2>&1
I believe exiting should not be forced in case a problem occurs when trying to
sighup innfeed.
Otherwise, rotation is half-done, and innd remains paused...
In my daily reports, I indeed once saw:
/home/news/bin/scanlogs: line 171: kill: (4240) - Aucun processus de ce type
Cannot flush innfeed logs.
ctlinnd: Must be running
[...]
I think the following change is enough.
I will run it a few days more before committing it to STABLE (therefore fixing
the current rotation issue).
As for CURRENT, the prerotatelog/postrotatelog new commands will allow to fix
all the bugs you mentioned.
--- scripts/scanlogs.in (r?vision 9463)
+++ scripts/scanlogs.in (copie de travail)
@@ -25,12 +25,18 @@
INNFEEDCONF=${PATHETC}/innfeed.conf
if [ -f "${INNFEEDCONF}" ]; then
INNFEEDLOG=`${AWK} '{gsub(/:|#/, " & ")} {if ($1 == "log-file" && $2 ==
":") print $3}' ${INNFEEDCONF}`
+ INNFEEDPIDFILE=`${AWK} '{gsub(/:|#/, " & ")} {if ($1 == "pid-file" && $2
== ":") print $3}' ${INNFEEDCONF}`
fi
INNFEED=
for F in "${INNFEEDLOG}" ; do
test -f "${MOST_LOGS}/${F}" && INNFEED="${INNFEED} ${MOST_LOGS}/${F}"
done
test -z "${INNFEED}" && test -f "${MOST_LOGS}/innfeed.log" &&
INNFEED="${MOST_LOGS}/innfeed.log"
+INNFEEDPID=
+for F in "${INNFEEDPIDFILE}" ; do
+ test -f "${PATHRUN}/${F}" && INNFEEDPID=`cat "${PATHRUN}/${F}"`
+done
+test -z "${INNFEEDPID}" && test -f "${PATHRUN}/innfeed.pid" && INNFEEDPID=`cat
"${PATHRUN}/innfeed.pid"`
NNTPSEND=${MOST_LOGS}/nntpsend.log
PERLNOCEM=${MOST_LOGS}/perl-nocem.log
SENDIHAVE=${MOST_LOGS}/send-ihave.log
@@ -112,8 +118,8 @@
PAUSED=false
ctlinnd -s pause "Flushing log and syslog files" 2>&1 && PAUSED=true
- # First, flush log files to be sure everything has been recorded
- # before rotating them.
+ ## First, flush log files to be sure everything has been recorded
+ ## before rotating them.
OUTPUT=`ctlinnd flushlogs 2>&1`
if [ "$OUTPUT" != "Ok" -a "$OUTPUT" != "In debug mode" ]; then
echo "$OUTPUT"
@@ -160,14 +166,9 @@
## Tally control messages if we logged them.
test -n "${CONTROL_DATA}" && cat ${CONTROL_DATA} | ${TALLY_CONTROL}
- # Flush again log files so that freshly rotated new log files
- # are properly taken into account.
- OUTPUT=`ctlinnd flushlogs 2>&1`
- if [ "$OUTPUT" != "Ok" -a "$OUTPUT" != "In debug mode" ]; then
- echo "$OUTPUT"
- echo 'Cannot flush logs.'
- rm -f ${LOCK}
- exit 1
+ ## Send a HUP signal to innfeed so that it reopens its log files.
+ if [ ! -z ${INNFEEDPID} ]; then
+ kill -HUP ${INNFEEDPID} > /dev/null 2>&1
fi
${PAUSED} && ctlinnd -s go "Flushing log and syslog files" 2>&1
In case you see something wrong or have been running fine a new version
of your original patch, do not hesitate to tell.
--
Julien ?LIE
? A program should always respond to the user in the way that
astonishes him least. ? (Plauger's Law of Least Astonishment)
------------------------------
Message: 4
Date: Thu, 30 May 2013 22:36:50 +0200
From: Florian Schlichting <[email protected]>
To: [email protected]
Subject: Re: [PATCH] innfeed does not reopen (rotated) log file
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Hi Julien,
> In case you see something wrong or have been running fine a new version
> of your original patch, do not hesitate to tell.
I've been owing you an answer for over a month, and I'm sorry this isn't
one either. I've been feeling that I should think things through
thoroughly once more, but the time to do that just hasn't materialized.
I'll make an effort to find some over the next few days, but feel free
to just commit whatever you think is reasonable.
Florian
------------------------------
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
End of inn-workers Digest, Vol 51, Issue 9
******************************************
