Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. RE: inn-2.6.0rc1 bug report (David Binderman)
2. Re: INN 2.6.0 release candidate (Dennis Preiser)
3. Re: inn-2.6.0rc1 bug report (Julien ?LIE)
4. Re: INN 2.6.0 release candidate (Julien ?LIE)
5. Use of nfswriter? (Julien ?LIE)
----------------------------------------------------------------------
Message: 1
Date: Sat, 2 May 2015 12:01:38 +0000
From: David Binderman <[email protected]>
To: Julien ?LIE <[email protected]>, "[email protected]"
<[email protected]>
Subject: RE: inn-2.6.0rc1 bug report
Message-ID: <[email protected]>
Content-Type: text/plain; charset="iso-8859-1"
Hello there,
----------------------------------------
> That's a good catch, thanks!
> It will be fixed for the 2.5.5 and 2.6.0 releases.
>
> Strange that I did not see that warning with various versions of gcc
> (4.7.2 to 5.1.0) and Clang 3.0-6.2 from Debian. What compiler do you use?
A static analyser called cppcheck, available from sourceforge.
http://cppcheck.sourceforge.net/
Recommended for C/C++ development work.
Regards
David Binderman
------------------------------
Message: 2
Date: Sat, 2 May 2015 16:45:40 +0200
From: Dennis Preiser <[email protected]>
To: [email protected]
Subject: Re: INN 2.6.0 release candidate
Message-ID: <[email protected]>
Content-Type: text/plain; charset=iso-8859-1
On Sat, May 02, 2015 at 12:14:25PM +0200, Julien ?LIE wrote:
> Here is a suggestion, similar to yours:
>
> --- configure.ac (r?vision 9831)
> +++ configure.ac (copie de travail)
> @@ -214,8 +214,9 @@
> fi
> ;;
>
> -dnl OSX needs -multiply_defined suppress.
> -*darwin*)
> +dnl OSX needs "-multiply_defined suppress" before this linker flag became
> +dnl obsolete (darwin13 is Mavericks, OS X v10.9).
> +*-darwin[0-9].*|*-darwin1[0-2].*)
> LDFLAGS="$LDFLAGS -multiply_defined suppress"
> ;;
>
After ./autogen configure looks like this:
| *-darwin0-9.*|*-darwin10-2.*)
| LDFLAGS="$LDFLAGS -multiply_defined suppress"
| ;;
I guess we need:
diff -urp inn-2.6.0rc1_orig/configure.ac inn-2.6.0rc1/configure.ac
--- inn-2.6.0rc1_orig/configure.ac 2015-03-25 21:36:36.000000000 +0100
+++ inn-2.6.0rc1/configure.ac 2015-05-02 16:30:19.000000000 +0200
@@ -214,8 +214,9 @@ dnl -g on link as well as compile for de
fi
;;
-dnl OSX needs -multiply_defined suppress.
-*darwin*)
+dnl OSX needs "-multiply_defined suppress" before this linker flag became
+dnl obsolete (darwin13 is Mavericks, OS X v10.9).
+*-darwin[[0-9]].*|*-darwin1[[0-2]].*)
LDFLAGS="$LDFLAGS -multiply_defined suppress"
;;
> Here is suggestion of patch that should fix the bug.
> The need was in fact to define sasl_callback_ft when it was not defined,
> and the first version that defines it is 2.1.25 (not 2.1.24).
>
> --- innfeed/imap_connection.c (r?vision 9831)
> +++ innfeed/imap_connection.c (copie de travail)
> @@ -52,8 +52,8 @@
> # include <sasl/sasl.h>
> # include <sasl/saslplug.h>
> # include <sasl/saslutil.h>
> -/* For Cyrus SASL versions < 2.1.24. */
> -# ifndef sasl_callback_ft
> +/* For Cyrus SASL versions < 2.1.25 (in hexadecimal notation below). */
> +# if !defined (SASL_VERSION_FULL) || SASL_VERSION_FULL < 0x020119
> typedef int (*sasl_callback_ft)(void);
> # endif
> #endif
This patch fixes the typedef issue.
> Do you confirm everything now works fine with these two patches?
I can confirm this with the revised configure.ac patch (doubled opening and
closing brackets).
Dennis
------------------------------
Message: 3
Date: Sat, 02 May 2015 18:23:32 +0200
From: Julien ?LIE <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Re: inn-2.6.0rc1 bug report
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi David,
>> Strange that I did not see that warning with various versions of gcc
>> (4.7.2 to 5.1.0) and Clang 3.0-6.2 from Debian. What compiler do you use?
>
> A static analyser called cppcheck, available from sourceforge.
>
> http://cppcheck.sourceforge.net/
>
> Recommended for C/C++ development work.
Thanks for the link, David. I also see that the Debian packages are
constantly checked, with the report available at:
http://cppcheck.sourceforge.net/devinfo/daca2-report/daca2.html
It permits to find another (p != '\0') that should be written (*p != '\0').
[inn-2.5.4/expire/fastrm.c:484]: (warning) Char literal compared with
pointer 'p'. Did you intend to dereference it?
It will be fixed in 2.5.5 and 2.6.0.
I keep the page in my bookmarks for future analysis!
Thanks again,
--
Julien ?LIE
? Les horizontales se rencontrent dans tous les milieux, les
parall?les jamais. ? (Alphonse Allais)
------------------------------
Message: 4
Date: Sat, 02 May 2015 18:23:55 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: INN 2.6.0 release candidate
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Dennis,
> --- inn-2.6.0rc1_orig/configure.ac 2015-03-25 21:36:36.000000000 +0100
> +++ inn-2.6.0rc1/configure.ac 2015-05-02 16:30:19.000000000 +0200
> @@ -214,8 +214,9 @@ dnl -g on link as well as compile for de
> fi
> ;;
>
> -dnl OSX needs -multiply_defined suppress.
> -*darwin*)
> +dnl OSX needs "-multiply_defined suppress" before this linker flag became
> +dnl obsolete (darwin13 is Mavericks, OS X v10.9).
> +*-darwin[[0-9]].*|*-darwin1[[0-2]].*)
> LDFLAGS="$LDFLAGS -multiply_defined suppress"
> ;;
OK, adopted. I have just committed this change. Thanks!
>> --- innfeed/imap_connection.c (r?vision 9831)
>> +++ innfeed/imap_connection.c (copie de travail)
>> @@ -52,8 +52,8 @@
>> # include <sasl/sasl.h>
>> # include <sasl/saslplug.h>
>> # include <sasl/saslutil.h>
>> -/* For Cyrus SASL versions < 2.1.24. */
>> -# ifndef sasl_callback_ft
>> +/* For Cyrus SASL versions < 2.1.25 (in hexadecimal notation below). */
>> +# if !defined (SASL_VERSION_FULL) || SASL_VERSION_FULL < 0x020119
>> typedef int (*sasl_callback_ft)(void);
>> # endif
>> #endif
>
> This patch fixes the typedef issue.
Perfect, then. Also committed.
Thanks again for your two bug reports. In case you notice something
else, do not hesitate to tell.
--
Julien ?LIE
? Les horizontales se rencontrent dans tous les milieux, les
parall?les jamais. ? (Alphonse Allais)
------------------------------
Message: 5
Date: Sat, 02 May 2015 19:24:56 +0200
From: Julien ?LIE <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Use of nfswriter?
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
Hi all,
Are there people here using NFS storage for their CNFS spool?
and does it work fine?
I ask because I am a bit puzzled by an issue cppcheck shows
in storage/cnfs/cnfs.c.
We have at the end of the cnfs_mapcntl() function "send = send",
which should be in fact "send = end". As the code currently is,
and also always was, it couldn't work because "send" is always
NULL (it is never affected to a value).
This function is only called when nfswriter is true in inn.conf.
cnfs_mapcntl(void *p, size_t length, int flags)
{
char *start, *end;
start = (char *)((size_t)p & ~(size_t)(pagesize - 1));
end = (char *)((size_t)((char *)p + length + pagesize) &
~(size_t)(pagesize - 1));
if (flags == MS_INVALIDATE) {
msync(start, end - start, flags);
} else {
static char *sstart, *send;
/* Don't thrash the system with msync()s - keep the last value
* and check each time, only if the pages which we should
* flush change actually flush the previous ones. Calling
* cnfs_mapcntl(NULL, 0, MS_ASYNC) then flushes the final
* piece */
if (start != sstart || end != send) {
if (sstart != NULL && send != NULL) {
msync(sstart, send - sstart, flags);
}
sstart = start;
send = send;
^^^^^^^^^^^^
}
}
}
--
Julien ?LIE
? Les horizontales se rencontrent dans tous les milieux, les
parall?les jamais. ? (Alphonse Allais)
------------------------------
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
End of inn-workers Digest, Vol 72, Issue 2
******************************************
