Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: INN patches following static analysis (Julien ?LIE)
2. Re: INN patches following static analysis (Julien ?LIE)
3. INN patches following static analysis (Richard Kettlewell)
4. Re: INN patches following static analysis (Richard Kettlewell)
----------------------------------------------------------------------
Message: 1
Date: Sun, 03 May 2015 17:31:48 +0200
From: Julien ?LIE <[email protected]>
To: "[email protected]" <[email protected]>
Cc: Richard Kettlewell <[email protected]>
Subject: Re: INN patches following static analysis
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Richard,
> I put INN through a static analyzer. There were quite a lot of
> issues detected; I've not studied them all yet but attached are some
> patches that address the first ones I looked at.
Many thanks for your patches. They are all integrated to CURRENT
(2.6.0). I will soon also commit them to STABLE (2.5.5).
> [PATCH 4/5] Paranoid checking of AUTHINFO GENERIC reply
>
> + Reply("%d Program error occurred\r\n", NNTP_FAIL_ACTION,
> + strerror(errno));
I removed the errno part in the commit.
> Subject: [PATCH 3/5] Correct sense of PERMgeneric reply
>
> The comment has always been wrong. The return value has been wrong
> for ~15 years. Perhaps it would be better to remove this code
> entirely.
Yep, that's a pretty good catch! I bet that nobody ever used AUTHINFO
GENERIC with INN 2.x...
--
Julien ?LIE
? ? Vous refusez de porter pilum ?
? Ben? On pr?f?re se faire porter p?les? ? (Ast?rix)
------------------------------
Message: 2
Date: Sun, 03 May 2015 19:18:44 +0200
From: Julien ?LIE <[email protected]>
To: "[email protected]" <[email protected]>
Cc: Richard Kettlewell <[email protected]>
Subject: Re: INN patches following static analysis
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Richard,
>>> [PATCH 4/5] Paranoid checking of AUTHINFO GENERIC reply
>>>
>>> + Reply("%d Program error occurred\r\n", NNTP_FAIL_ACTION,
>>> + strerror(errno));
>>
>> I removed the errno part in the commit.
>
> Oh, well spotted, sorry about that.
No problem. I wish to thank you again for your help to improve the
robustness of INN.
>> Subject: [PATCH 3/5] Correct sense of PERMgeneric reply
>>
>> The return value has been wrong for ~15 years.
>
> I bet that nobody ever used AUTHINFO GENERIC with INN 2.x...
In fact, since INN 2.4.0 because the code up to 2.3.5 seems right.
If you don't mind, I will add your name to our CONTRIBUTORS file as I
see you currently are not mentioned herein.
--
Julien ?LIE
? ? Vous refusez de porter pilum ?
? Ben? On pr?f?re se faire porter p?les? ? (Ast?rix)
------------------------------
Message: 3
Date: Sun, 03 May 2015 15:36:07 +0100
From: Richard Kettlewell <[email protected]>
To: [email protected]
Subject: INN patches following static analysis
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
Hello,
I put INN through a static analyzer. There were quite a lot of issues
detected; I've not studied them all yet but attached are some patches
that address the first ones I looked at.
The results pass 'make check' but I've not attempted to install and run
the modified version.
ttfn/rjk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Avoid-violating-C-aliasing-rules.patch
Type: text/x-patch
Size: 1313 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20150503/1db7e2ff/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Paranoid-checking-of-AUTHINFO-GENERIC-reply.patch
Type: text/x-patch
Size: 1375 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20150503/1db7e2ff/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Correct-sense-of-PERMgeneric-reply.patch
Type: text/x-patch
Size: 1374 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20150503/1db7e2ff/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Don-t-dereference-a-null-pointer-if-there-are-no-acc.patch
Type: text/x-patch
Size: 606 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20150503/1db7e2ff/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Correctly-log-malformed-Xref-fields.patch
Type: text/x-patch
Size: 942 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20150503/1db7e2ff/attachment-0009.bin>
------------------------------
Message: 4
Date: Sun, 03 May 2015 16:41:48 +0100
From: Richard Kettlewell <[email protected]>
To: "inn-workers\@lists.isc.org" <[email protected]>
Subject: Re: INN patches following static analysis
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
On 2015-05-03 16:31, Julien ?LIE wrote:
> Hi Richard,
>> [PATCH 4/5] Paranoid checking of AUTHINFO GENERIC reply
>>
>> + Reply("%d Program error occurred\r\n", NNTP_FAIL_ACTION,
>> + strerror(errno));
>
> I removed the errno part in the commit.
Oh, well spotted, sorry about that.
ttfn/rjk
------------------------------
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
End of inn-workers Digest, Vol 72, Issue 3
******************************************
