Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Today's patches (Richard Kettlewell)
2. Re: Today's patches (Bo Lindbergh)
----------------------------------------------------------------------
Message: 1
Date: Mon, 04 May 2015 20:55:32 +0100
From: Richard Kettlewell <[email protected]>
To: [email protected]
Subject: Today's patches
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
Three more patches attached, with embedded descriptions. My testing
situation has improved a bit too, and I can confirm that INN still runs
with the attached changes (although I've not exercised it very heavily).
As before the starting point is static analysis results.
I noticed this:
/* A magic number for the group.index file so that we can later change the
format in a backward-compatible fashion. */
#define TDX_MAGIC (~(0xf1f0f33d))
Why is it defined in the inverse? i.e. why not the much clearer:
#define TDX_MAGIC 0x0e0f0cc2
ttfn/rjk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Initialize-ARTHANDLE-objects-before-passing-by-value.patch
Type: text/x-patch
Size: 2100 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20150504/0aedcbff/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Remove-redundant-broken-code.patch
Type: text/x-patch
Size: 1272 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20150504/0aedcbff/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Correct-remap-check-in-tradindexed-group-lookup.patch
Type: text/x-patch
Size: 2157 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20150504/0aedcbff/attachment-0005.bin>
------------------------------
Message: 2
Date: Tue, 5 May 2015 05:38:05 +0200
From: Bo Lindbergh <[email protected]>
To: Richard Kettlewell <[email protected]>
Cc: [email protected]
Subject: Re: Today's patches
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Quoth Richard Kettlewell:
> #define TDX_MAGIC (~(0xf1f0f33d))
>
> Why is it defined in the inverse?
"fifofeed"
/Bo Lindbergh
------------------------------
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
End of inn-workers Digest, Vol 72, Issue 4
******************************************