Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: Please generate the ChangeLog file also for snapshots
(Marco d'Itri)
2. Re: Please generate the ChangeLog file also for snapshots
(Russ Allbery)
3. Re: Please generate the ChangeLog file also for snapshots
(Noel Butler)
4. Re: Please generate the ChangeLog file also for snapshots
(Russ Allbery)
5. Re: Please generate the ChangeLog file also for snapshots
(Julien ?LIE)
6. Re: Please generate the ChangeLog file also for snapshots
(Julien ?LIE)
----------------------------------------------------------------------
Message: 1
Date: Wed, 10 Jun 2020 14:34:22 +0200
From: Marco d'Itri <[email protected]>
Cc: [email protected]
Subject: Re: Please generate the ChangeLog file also for snapshots
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
On Jun 08, Julien ?LIE <[email protected]> wrote:
> Is it really needed for Debian packages? (I see that you added a patch to
> skip its installation if the upstream changelog is missing)
It is not strictly needed, but I added that workaround expecting that
this would be solved in a future release.
Another annoying issue is that this causes useless changes in the git
repository every time that I have to switch between a release and
a snapshot.
Maybe the changelog should just be committed to the repository at
release time?
> By the way, thanks for the new Debian package of STABLE 1st June.
I suggest that you have a look at the systemd integration patch but wait
to merge it, because socket activation does not work yet with xexec.
--
ciao,
Marco
------------------------------
Message: 2
Date: Wed, 10 Jun 2020 14:06:14 -0700
From: Russ Allbery <[email protected]>
To: [email protected]
Subject: Re: Please generate the ChangeLog file also for snapshots
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
Marco d'Itri <[email protected]> writes:
> On Jun 08, Julien ?LIE <[email protected]> wrote:
>> Is it really needed for Debian packages? (I see that you added a patch to
>> skip its installation if the upstream changelog is missing)
> It is not strictly needed, but I added that workaround expecting that
> this would be solved in a future release.
> Another annoying issue is that this causes useless changes in the git
> repository every time that I have to switch between a release and
> a snapshot.
> Maybe the changelog should just be committed to the repository at
> release time?
Does anyone use the ChangeLog file? Maybe we should just stop generating
one. We ship NEWS, which is what most people care about, and the source
repository is public and easily browsable if anyone wants the detailed
list of changes.
--
Russ Allbery ([email protected]) <https://www.eyrie.org/~eagle/>
Please send questions to the list rather than mailing me directly.
<https://www.eyrie.org/~eagle/faqs/questions.html> explains why.
------------------------------
Message: 3
Date: Thu, 11 Jun 2020 09:17:50 +1000
From: Noel Butler <[email protected]>
To: [email protected]
Subject: Re: Please generate the ChangeLog file also for snapshots
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"
On 11/06/2020 07:06, Russ Allbery wrote:
> Does anyone use the ChangeLog file? Maybe we should just stop generating
> one. We ship NEWS, which is what most people care about, and the source
> repository is public and easily browsable if anyone wants the detailed
> list of changes.
First thing I look for is Changelog file, i stopped reading projects
(not many left that bother with) NEWS files because they were not as
detailed if updated at all.
Perhaps NEWS is what needs deprecating.
--
Kind Regards,
Noel Butler
This Email, including attachments, may contain legally
privileged
information, therefore remains confidential and subject to copyright
protected under international law. You may not disseminate any part of
this message without the authors express written authority to do so. If
you are not the intended recipient, please notify the sender then delete
all copies of this message including attachments immediately.
Confidentiality, copyright, and legal privilege are not waived or lost
by reason of the mistaken delivery of this message.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20200611/5462cfcd/attachment-0001.htm>
------------------------------
Message: 4
Date: Wed, 10 Jun 2020 17:54:57 -0700
From: Russ Allbery <[email protected]>
To: [email protected]
Subject: Re: Please generate the ChangeLog file also for snapshots
Message-ID: <[email protected]>
Content-Type: text/plain
Noel Butler <[email protected]> writes:
> On 11/06/2020 07:06, Russ Allbery wrote:
>> Does anyone use the ChangeLog file? Maybe we should just stop
>> generating one. We ship NEWS, which is what most people care about,
>> and the source repository is public and easily browsable if anyone
>> wants the detailed list of changes.
> First thing I look for is Changelog file, i stopped reading projects
> (not many left that bother with) NEWS files because they were not as
> detailed if updated at all.
> Perhaps NEWS is what needs deprecating.
Do you find that true of INN's NEWS file? My feeling is that it's rather
detailed, and I can't imagine what value you would get out of the
ChangeLog that isn't in NEWS. (I personally have never read the ChangeLog
file except to verify that the generation of it worked properly.)
--
Russ Allbery ([email protected]) <https://www.eyrie.org/~eagle/>
Please send questions to the list rather than mailing me directly.
<https://www.eyrie.org/~eagle/faqs/questions.html> explains why.
------------------------------
Message: 5
Date: Thu, 11 Jun 2020 09:14:27 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: Please generate the ChangeLog file also for snapshots
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Noel,
> First thing I look for is Changelog file, i stopped reading? projects
> (not many left that bother with) NEWS files because they were not as
> detailed if updated at all.
>
> Perhaps NEWS is what needs deprecating.
NEWS:
https://www.eyrie.org/~eagle/software/inn/docs/news.html
ChangeLog:
https://inn.eyrie.org/trac/log/trunk?action=stop_on_copy&mode=stop_on_copy&rev=10382&stop_rev=&limit=200&verbose=on
Could you please provide examples of the kind of details you find
interesting in ChangeLog that aren't in NEWS?
--
Julien ?LIE
??Sol lucet omnibus.??
------------------------------
Message: 6
Date: Thu, 11 Jun 2020 09:35:35 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: Please generate the ChangeLog file also for snapshots
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Marco,
>> Is it really needed for Debian packages? (I see that you added a patch to
>> skip its installation if the upstream changelog is missing)
> It is not strictly needed, but I added that workaround expecting that
> this would be solved in a future release.
Each time a release is done, we update Makefile.global.in to bump:
VERSION = 2.7.0
Maybe we should just add below something like:
CHANGELOG_REV = 9042
And give that revision number as argument to the script that generates
the ChangeLog file. It would then be automatic (no longer prompting for
a prefix to strip and the date YYYY-MM-DD of the start of ChangeLog).
If of course we decide to keep ChangeLog at all.
>> By the way, thanks for the new Debian package of STABLE 1st June.
> I suggest that you have a look at the systemd integration patch but wait
> to merge it, because socket activation does not work yet with xexec.
https://salsa.debian.org/md/inn2/-/commit/32d4faf47cb0387f42362c0340357b3e3434b74b
In configure.ac:
if pkg-config libsystemd 2> /dev/null; then
LIBSYSTEMD_LIBS=`pkg-config --libs libsystemd`
AC_SUBST([LIBSYSTEMD_LIBS])
AC_DEFINE([HAVE_LIBSYSTEMD], 1, [Define if libsystemd is available.])
fi
When integrating systemd support in INN, we'll use the portable
RRA_LIB_SYSTEMD_DAEMON_OPTIONAL m4 macro from rra-c-util:
https://github.com/rra/rra-c-util/blob/master/m4/systemd.m4
https://github.com/rra/rra-c-util/blob/master/portable/sd-daemon.h
https://salsa.debian.org/md/inn2/-/commit/2cde1af9acaac257ac4fef3cc1ffff1315e80710
"Enable support for Python filters"
In innd/python.c, you should free(path) before returning.
https://salsa.debian.org/md/inn2/-/commit/64a6d34e1956f7133afd6ba132ae469d19a657c0
"Make SIGTERM behave exactly like ctlinnd shutdown"
Should it be merged to upstream? (OK for me)
--
Julien ?LIE
??Sol lucet omnibus.??
------------------------------
Subject: Digest Footer
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
------------------------------
End of inn-workers Digest, Vol 120, Issue 3
*******************************************
