Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: [PATCH 0/4] Improve delayer (Julien ?LIE)
2. Re: [PATCH 1/2] storage: Add "filtered" option, to store
based on the filter's decision (Julien ?LIE)
----------------------------------------------------------------------
Message: 1
Date: Sat, 20 Jan 2024 23:30:11 +0100
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: [PATCH 0/4] Improve delayer
Message-ID: <[email protected]>
Content-Type: text/plain; charset=UTF-8; format=flowed
Hi Christoph,
> a while ago I re-discovered the delayer as a way to increase efficiency
> of NoCeM notice handling: By deliberately delaying articles from the
> well-known spam site, the NoCeMs will arrive first, blocking the spam's
> Message-IDs. As a result, users will not see the spam at all.
>
> However, I found this little program could need some love, so there's
> some code cleanup, documentation, and a bugfix. And new features, most
> notably persistence for the lines not sent yet.
>
> Christoph Biedl (4):
> delayer: Code cleanup
> delayer: Add documentation
> delayer: Introduce options for buffering and persistence
> delayer: Handle drained queue properly
>
> contrib/README | 2 +-
> contrib/delayer.in | 211 ++++++++++++++++++++++++++++++++++++++-------
> 2 files changed, 179 insertions(+), 34 deletions(-)
Thanks again for your patches. They are now merged upstream.
I've added a sentence about delayer in the manual pages of innfeed and
newsfeeds, as well as a commented innfeed-delayed! entry in the
newsfeeds sample.
Also, I've tried to detail a bit more the manual page of delayer. I
hope the result is fine. Do not hesitate to speak up in case something
needs changing.
--
Julien ?LIE
??Open the black window and type text, to fix the network.??
------------------------------
Message: 2
Date: Sun, 21 Jan 2024 09:13:49 +0100
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: [PATCH 1/2] storage: Add "filtered" option, to store
based on the filter's decision
Message-ID: <[email protected]>
Content-Type: text/plain; charset=UTF-8; format=flowed
Hi Christoph,
> @@ -643,6 +653,7 @@ SMgetsub(const ARTHANDLE article)
> && (!sub->maxsize || (article.len <= sub->maxsize))
> && (!sub->minexpire || article.expires >= sub->minexpire)
> && (!sub->maxexpire || (article.expires <= sub->maxexpire))
> + && (sub->filtered == article.filtered)
> && MatchGroups(article.groups, article.groupslen, sub->pattern,
> sub->exactmatch)) {
> if (InitMethod(typetoindex[sub->type]))
When dontrejectfiltered is set in inn.conf, I am under the impression
that the above additional condition will break storage for people who do
not use the filtered parameter.
If I do not have the new filtered parameter set on any storage class,
then filtered articles will no longer be stored ("no matching entry in
storage.conf").
I am unsure how to best deal with that.
If no storage class has a filtered parameter, fall back to discard that
condition?
Or consider that using dontrejectfiltered implies the use of the
filtered parameter in storage.conf, and then it would be a change to
delay for a major release (INN 2.8.0). Yet, I would prefer not to
correlate the two settings, and allow news admins to use
dontrejectfiltered without having to fiddle with the filtered parameter.
--
Julien ?LIE
??Si bene commemini, causae sunt quinque bibendi?: Hospitis aduentus,
praesens sitis atque futura, Et uini bonitas, et quaelibet altera
causa.??
------------------------------
Subject: Digest Footer
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
------------------------------
End of inn-workers Digest, Vol 157, Issue 14
********************************************
