JC, Moving extensions form ITKv3 to ITKv4 is only problematic in a few registration cases. In fact, I've been working through many extensions already to make them ITKv4 compliant (mostly in the DWI world), and I've found that no changes are necessary in most cases.
There are still 2 items that must be addressed in the ITKv4 registration framework, and those are on the TODO list for this spring. Perhaps we can attack them at the NA-MIC meeting in Utah. Hans -----Original Message----- From: Matt McCormick <[email protected]> Date: Sunday, December 15, 2013 10:46 PM To: Jean-Christophe Fillion-Robin <[email protected]> Cc: Steve Pieper <[email protected]>, Slicer Development <[email protected]>, Hans Johnson <[email protected]>, ITK <[email protected]> Subject: Re: [slicer-devel] [Insight-developers] 4GB images on windows Hi Jc, It appears that ITKV3_COMPATIBILITY and ITK_USE_64BITS_IDS are incompatible according to itkIntTypes.h [1] and the original commit [2]. Hope this helps, Matt [1] https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Core/C ommon/include/itkIntTypes.h#L122 [2] http://itk.org/gitweb?p=ITK.git;a=commit;h=fca715855365f739d03511f335093ca3 677c3635 On Sun, Dec 15, 2013 at 3:19 AM, Jean-Christophe Fillion-Robin <[email protected]> wrote: > Looking at this in more details, within the ITK CMakeLists, I can observe > that the option "ITK_USE_64BITS_IDS" is exposed only if >ITKV3_COMPATIBILITY > is disabled. See [1] > > Considering that Slicer builds ITK with ITKV3_COMPATIBILITY enabled, >will > that cause any issues ? > > Note: ITKV3_COMPATIBILITY is currently required for some extension, if > needed I guess we could suggest extension maintainer to update their code > ... > > Thanks > Jc > > [1] https://github.com/Kitware/ITK/blob/master/CMakeLists.txt#L247-250 > > > > On Fri, Dec 13, 2013 at 3:53 PM, Steve Pieper <[email protected]> wrote: >> >> @Jc - yes, let's turn it on and see how it goes! >> >> >> On Fri, Dec 13, 2013 at 3:01 PM, Johnson, Hans J >><[email protected]> >> wrote: >>> >>> +1 >>> >>> I also agree with Steve that this change has a very high likely hood of >>> occurring without problems. >>> >>> Hans >>> >>> >>> From: Jean-Christophe Fillion-Robin <[email protected]> >>> Date: Friday, December 13, 2013 at 1:52 PM >>> To: Steve Pieper <[email protected]> >>> Cc: Slicer Development <[email protected]>, ITK >>> <[email protected]> >>> Subject: Re: [Insight-developers] 4GB images on windows >>> >>> +1 >>> >>> @Steve: I propose we turn the flag ON on the Slicer dashboard machine >>>for >>> the weekend. If things go well, we enabled it by default on Monday. >>> >>> What do you think ? >>> >>> >>> On Fri, Dec 13, 2013 at 2:37 PM, Steve Pieper <[email protected]> >>>wrote: >>>> >>>> Hi Brad - >>>> >>>> I have not tried, but I'll bet turning the flag on in slicer would >>>>work >>>> and we could set that as a default. >>>> >>>> Even better though I think it would make sense for this to be the >>>> default for any ITK 64 bit build. >>>> >>>> -Steve >>>> >>>> >>>> On Fri, Dec 13, 2013 at 2:16 PM, Bradley Lowekamp >>>> <[email protected]> wrote: >>>>> >>>>> Hello, >>>>> >>>>> I have just noticed that in SimpleITK on windows 64-bits that images >>>>> are limited to 2GB (maybe 4GB for some opts) because the "long" type >>>>>is >>>>> still used for size by default. >>>>> >>>>> ITK has the CMake variable ITK_USE_64BITSIDS to change this. >>>>> >>>>> https://github.com/Kitware/ITK/blob/master/CMakeLists.txt#L248 >>>>> >>>>> >>>>>https://github.com/Kitware/ITK/blob/master/Modules/Core/Common/include >>>>>/itkIntTypes.h#L122 >>>>> >>>>> I also noticed that Slicer3D does not have this parameter set so it's >>>>> ITK image size is limited. >>>>> >>>>> Are we going to make this enabled by default in ITK at some point? >>>>> >>>>> Has anyone tried enabling this is Slicer? >>>>> >>>>> I am going to start with SimpleITK, and wondering what to expect. >>>>> >>>>> Thanks, >>>>> Brad >>>>> >>>>> >>>>> _______________________________________________ >>>>> Powered by www.kitware.com >>>>> >>>>> Visit other Kitware open-source projects at >>>>> http://www.kitware.com/opensource/opensource.html >>>>> >>>>> Kitware offers ITK Training Courses, for more information visit: >>>>> http://kitware.com/products/protraining.php >>>>> >>>>> Please keep messages on-topic and check the ITK FAQ at: >>>>> http://www.itk.org/Wiki/ITK_FAQ >>>>> >>>>> Follow this link to subscribe/unsubscribe: >>>>> http://www.itk.org/mailman/listinfo/insight-developers >>>>> >>>>> >>>>> The information in this e-mail is intended only for the person to >>>>>whom >>>>> it is >>>>> addressed. If you believe this e-mail was sent to you in error and >>>>>the >>>>> e-mail >>>>> contains patient information, please contact the Partners Compliance >>>>> HelpLine at >>>>> http://www.partners.org/complianceline . If the e-mail was sent to >>>>>you >>>>> in error >>>>> but does not contain patient information, please contact the sender >>>>>and >>>>> properly >>>>> dispose of the e-mail. >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Kitware offers ITK Training Courses, for more information visit: >>>> http://kitware.com/products/protraining.php >>>> >>>> Please keep messages on-topic and check the ITK FAQ at: >>>> http://www.itk.org/Wiki/ITK_FAQ >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://www.itk.org/mailman/listinfo/insight-developers >>>> >>> >>> >>> >>> -- >>> +1 919 869 8849 >>> >>> >>> ________________________________ >>> Notice: This UI Health Care e-mail (including attachments) is covered >>>by >>> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is >>> confidential and may be legally privileged. If you are not the >>>intended >>> recipient, you are hereby notified that any retention, dissemination, >>> distribution, or copying of this communication is strictly prohibited. >>> Please reply to the sender that you have received the message in >>>error, then >>> delete it. Thank you. >>> ________________________________ >> >> > > > > -- > +1 919 869 8849 > > _______________________________________________ > slicer-devel mailing list > [email protected] > http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel > To unsubscribe: send email to >[email protected] > with unsubscribe as the subject > >http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developer >s/FAQ > > > The information in this e-mail is intended only for the person to whom >it is > addressed. If you believe this e-mail was sent to you in error and the > e-mail > contains patient information, please contact the Partners Compliance > HelpLine at > http://www.partners.org/complianceline . If the e-mail was sent to you in > error > but does not contain patient information, please contact the sender and > properly > dispose of the e-mail. > ________________________________ Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you. ________________________________ _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
