Sundar, I have addressed all of your code review comments below. I will be sending out a link to a new webrev as soon as I finish the rest of my code review feedback. Please let me know if you have further questions regarding my responses.
thanks, Moriah Sundar Yamunachari wrote: > Moriah, > > I looked only at the changes and these comments are for the webrev2 > (http://cr.opensolaris.org/~mwaterl/6739234.changes_only/webrev/ ) > > Some general comments > > 1. Several Files have changes only in the # include header files. The > copyrights were not updated. Fixed. Updated 5 files with 2009 copyright. > 2. Some files have 2006 in the new copyrights. Is that correct? Fixed. There were several files that had been updated in December after I had already pulled the bits from the Legacy Install gate. > usr/src/cmd/Makefile.cmd: > > Lines 144 and 145 looks identical. Fixed > Lines 314-315 and 324-325 are same. Fixed > usr/src/cmd/svr4pkg/Makefile: > > 31-45: Do these directories have some dependencies? Whether any of > the directories should be built before other directories? If there are > no dependencies, what order should they be listed? Unless there is a > dependency, installf can be moved to the top of the list. Fixed. There are no dependencies between the package commands so I ordered directories alphabetically. > usr/src/cmd/svr4pkg/hdrs/libadm.h and other files: > What about copyright change? You don't change it because of no change > in the code? Fixed. There were several files that had been updated in December after I had already pulled the bits from the Legacy Install gate. I grabbed all the files associated with the putback and have updated my workspace. > usr/src/cmd/svr4pkg/installf/main.c: > > Update copyright to 2009. Fixed. > usr/src/cmd/svr4pkg/libinst/fixpath.c: > > Update copyright to 2009. Fixed. > usr/src/cmd/svr4pkg/libinst/pkgdbmerg.c: > > Update copyright to 2009. Is it intentional to change the copyrights > to 2006 (from 2008) and corresponding changes in lines 196-198? I don't > see any explanation for the code change.Fixed. There were several files that > had been updated in December after I had already pulled the bits from the Legacy Install gate. I grabbed all the files associated with the putback and have updated my workspace. > usr/src/cmd/svr4pkg/pkgmk/Makefile: > > 29-32: quit.o goes before splpkgmap.o (alphabetical order) > usr/src/cmd/svr4pkg/pkgscripts/Makefile: Fixed. > Update copyright to 2009. Fixed. > 32-38: Move r.awk up after i.awk Moved list so that it is now in alphabetical order > usr/src/lib/libinstzones/common/zones.c: > > Where does the changes come from? Did the install code have a copy of > the same file and modified the code? Is it true for all the files under > usr/src/lib/libinstzones/common directory listed in the webrev? All of the changes under libinstzones came from the code in the slim_source gate. This code originally was libspmizones and was pulled over to the Caiman gate when it was originally spawned. > usr/src/lib/libpkg/common/handlelocalfs.c: > > Why did you update the year to 2009 in the copyrights here? I don't > see any code changes. Same comment for p12lib.c, and p12lib.h. I had changed the copyright date for handlelocalfs.c because I had added a new license.. I see what you mean though and I will revert the date back to 2007. I removed the CDDL that I had added to p12lib.c and p12lib.h as Jim pointed out that my changes were not appropriate. I also changed the copyrights back to 2003.
