<comments in-line>
Mark J. Nelson wrote:
> Moriah Waterland wrote:
> > Mark,
> >
> >> usr/src/cmd/svr4pkg/pkgscripts:
> >> - What is "special_contents" used for? (Or is it unreferenced?)
> >> - None of the scripts specify an interpreter--I think they should.
> >> (#!/bin/sh)
> > It appears to just be unreferenced junk that is still laying around. I
> > removed the file (hg remove) and it didn't appear to cause any issues.
>
> That looks like an answer about special_contents, but not about adding
> an interpreter line to your scripts?
>
After looking at other class action scripts under usr/src/cmd, it
appeared to me that they were not supposed to specify an interpreter.
But, I took a look at the class action scripts that you pointed me to
(usr/src/pkgdefs/common_files/i.* and r.*) and this makes sense.
I added:
#!/bin/sh
to all the scripts under usr/src/svr4pkg/pkgscripts.
> >> - Usually, if you want a script to be executable, you name it
> >> "blah.sh," and use the ".sh:" suffix rule to create "blah." You
> >> wouldn't even need to update the Makefile to accomplish this--simply
> >> rename the scripts, and it should work correctly.
>
> > Done, these files are actually just class action scripts. I was setting
> > the permissions because that was how it was handled in the Legacy
> > Install gate. After looking at other examples, I concluded that I do
> > not need to explicitly set the permissions for the scripts.
>
> I'll want to look at this in the followup webrev; sounds right.
>
> >> usr/src/lib/libinstzones/Makefile:
> >> usr/src/lib/libpkg/Makefile:
> >> _msg: Since you're already enumerating the object files in
> >> Makefile.com, and you're preprocessing for message extraction, it
> >> makes much more sense to handle _msg in Makefile.com, instead of
> >> here. And if you're really being clever, for libinstzones, you only
> >> need to extract from zones_strings.h, using the -a flag for xgettext,
> >> and not calling the preprocessor.
> > I ended up leaving this alone. I would have liked to have cleaned this
> > up, but I have already had way too much fun with these Makefiles and
> > have limited resources. Thank you for the advice and I will file a bug
> > on this next week.
>
> You didn't change anything about this?
>
Mark, thanks for the time and the chat about this issue yesterday. As we
agreed, I'm leaving this alone for now, and filed 6842322 to track the
issue.
-Moriah
