On Sat, 12 Jun 2010 05:21:18 -0400, Andy Lutomirski <[email protected]> wrote: > Commit 7a772c492fcfffae812ffca78a628e76fa57fe58 has two bugs which > made the hotplug problems on my laptop worse instead of better. > > First, it did not, in fact, disable the CRT plug interrupt -- it > disabled all the other hotplug interrupts. It seems rather doubtful > that that bit of the patch fixed anything, so let's just remove it. > (If you want to add it back, you probably meant ~CRT_HOTPLUG_INT_EN.) > > Second, on at least my GM45, setting CRT_HOTPLUG_ACTIVATION_PERIOD_64 > and CRT_HOTPLUG_VOLTAGE_COMPARE_50 (when they were previously unset) > causes a hotplug interrupt about three seconds later. The old code > never restored PORT_HOTPLUG_EN so this could only happen once, but > they new code restores those registers. So just set those bits when > we set up the interrupt in the first place. > > Signed-off-by: Andy Lutomirski <[email protected]>
Applied to for-linus. Thanks for tracking this down!
pgpW3gLPqL97x.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
