On Tue, 5 Apr 2011 10:24:18 +0100, Chris Wilson <[email protected]> wrote: > Toggle the Software Clear Interrupt bit which resets the controller to > clear any prior BUS_ERROR condition before we begin to use the > controller in earnest.
We do this in two places now, do we want to share the code? > + int reg_offset; > + > + reg_offset = 0; > if (HAS_PCH_SPLIT(dev)) > - I915_WRITE(PCH_GMBUS0, 0); > - else > - I915_WRITE(GMBUS0, 0); > + reg_offset = PCH_GMBUS0 - GMBUS0; > + > + /* First reset the controller by toggling the Sw Clear Interrupt. */ > + I915_WRITE(GMBUS1 + reg_offset, GMBUS_SW_CLR_INT); > + I915_WRITE(GMBUS1 + reg_offset, 0); > + > + /* Then mark the controller as disabled. */ > + I915_WRITE(GMBUS0 + reg_offset, 0); That's really ugly register addressing, but it looks like a common idiom in this file... -- [email protected]
pgpSLIU6yencK.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
