On Wed, 06 Apr 2011 07:59:37 +0100, Chris Wilson <[email protected]> 
wrote:

> I'd prefer to keep the mucking around with intel_watermak_params in the
> one spot. How about:

My concern is that g4x_compute_wm0 is now different from
ironlake_compute_wm0, which seems like a potential trap for the
unwary.

> -     *plane_wm = entries + display->guard_size;
> +     *plane_wm += entries;
...
> -     *cursor_wm = entries + cursor->guard_size;
> +     *cursor_wm += entries;

Uh, no. If we find out that '0' is the right value for the off-case, I
don't want to discover that we forgot to reset these...

-- 
[email protected]

Attachment: pgp5uQc7f72ty.pgp
Description: PGP signature

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to