Am Dienstag, den 12.04.2011, 09:43 +0100 schrieb Chris Wilson: > On Tue, 12 Apr 2011 10:34:41 +0200, Paul Menzel > <[email protected]> wrote: > > Am Dienstag, den 12.04.2011, 06:51 +0100 schrieb Chris Wilson: > > > This fixes a regression from 7b334fcb45b757ffb093696ca3de1b0c8b4a33f1. > > > > To quote Mark Brown [1]. > > > > Always include the subject line of the commit in patches - > > readers are unlikely to have memorised commit IDs. > > Does it really help to include the subject as well? I suppose it will help > in the case where the patch has been cherry-picked into other trees, > stable for instance. However, I truly didn't expect anyone to remember the > original commit as the first thing I do is to read through the identified > commit to try and understand the subsequent patch in context.
In my opinion the reason is especially the first one you mentioned. Thanks, Paul
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
