I have discussed this with Chris in my earlier patch. This change is a clean-up, since ring_put_irq and ring_get_irq are only used by bsd_ring_put_irq and bsd_ring_get_irq.
And once this change is made, it is more clear to see the difference between g4x and ironlake BSD interrupt control interface, because they are handled in a single function and they are different at the interrupt mask reg addresss as well as the interrupt flag . Thanks Feng, Boqun -----Original Message----- From: Keith Packard [mailto:[email protected]] Sent: Thursday, April 28, 2011 12:43 AM To: Feng, Boqun; [email protected] Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915:merge ring_put/get_irq into bsd_ring_put/get_irq On Wed, 27 Apr 2011 15:41:18 +0800, "Feng, Boqun" <[email protected]> wrote: > Remove ring_put_irq/ring_get_irq:drivers/gpu/drm/i915/intel_ringbuffer.c > , they are only used by bsd_ring_put_irq/bsd_ring_get_irq. > Expand the code in bsd_ring_put_irq/bsd_ring_get_irq. Why is this change useful? -- [email protected] _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
