On Thu, 28 Apr 2011 15:43:10 -0700 Keith Packard <[email protected]> wrote:
> On Thu, 28 Apr 2011 15:12:54 -0700, Jesse Barnes <[email protected]> > wrote: > > > + if (IS_GEN6(dev)) { > > + temp &= ~FDI_LINK_TRAIN_NONE; > > + temp |= FDI_LINK_TRAIN_NONE | FDI_TX_ENHANCE_FRAME_ENABLE; > > + } else if (IS_IVYBRIDGE(dev)) { > > + temp &= ~FDI_LINK_TRAIN_NONE_IVB; > > + temp |= FDI_LINK_TRAIN_NONE_IVB | FDI_TX_ENHANCE_FRAME_ENABLE; > > + } > > This seems inconsistent using IS_GEN6 for SNB and IS_IVYBRIDGE for IVB? Yes, there are several IS_GEN checks that I'd argue are wrong, I can clean them up in a subsequent. -- Jesse Barnes, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
