On Fri, 13 May 2011 10:19:52 +0100, Chris Wilson <[email protected]> 
wrote:
> On Thu, 12 May 2011 17:34:49 -0700, Keith Packard <[email protected]> wrote:
> > On Thu, 12 May 2011 22:17:14 +0100, Chris Wilson <[email protected]> 
> > wrote:
> > > The computation of the first-level watermarks for g4x and gen5+ are
> > > based on the same algorithm, so we can refactor those code paths to
> > > use a single function.
> > 
> > g4x_compute_wm0 takes a plane. ironlake_compute_wm0 takes a pipe. The
> > change implicitly assumes that pipe == plane on ironlake. Please clarify?
> 
> We lucked out. It should have been a plane on Ironlake as well.
> Fortunately on ILK+ each pipe is slaved to one (identically numbered)
> plane.

Heh. Please make sure you mention stuff like that in commit messages
when you find them.

-- 
[email protected]

Attachment: pgp5s5W8cHYLn.pgp
Description: PGP signature

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to