On 06/07/2011 12:34 PM, Kristian Høgsberg wrote:
Hi,
Here's a handful of patches that try to replace most of our chipset
feature checking with data in a new struct intel_chipset. It uses the
new PCI ID list infrastructure and eliminates all IS_FOO macros in
favor of a per-family chipset info struct. Actually, I was surprised
how much in the driver is really just a gen check, but there are a few
cases where we have to check a certain feature, as well as all the
gen4+ urb and thread limits (includes the recent fix for swapped VS
entry counts).
The series compiles and passes casual testing for me, but I've not run
piglit on it yet.
Kristian
This patchset is fantastic. Way better than what I'd been doing. I'm
tidying it up a bit and working on a bunch of follow-on cleanups...I'll
send out a proposed replacement series tomorrow.
The only concern I have is with the intel_decode changes to use gen. I
like the idea, but I'm afraid it may get us into trouble: What if we
need G45 specific decoding? We'll -certainly- need Gen 7.5 specific
dumping (over and above Gen7), eventually.
ickle's idea to use gen 70 and 75 would solve that...though, in general
I agree with Eric in preferring chipset->gen >= 7 and chipset->is_name.
--Kenneth
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
