On Tue, 12 Jul 2011 17:37:59 -0400, Adam Jackson <[email protected]> wrote: > Signed-off-by: Adam Jackson <[email protected]>
> +# define DP_DWN_STRM_PORT_TYPE_TMDS (2 << 1) This could be labeled TYPE_DVI_OR_HDMI according to the DP 1.1a spec. > - I find the blank lines useful in this file; they separate lists of values for different fields. > -#define DP_INTERLANE_ALIGN_DONE (1 << 0) > -#define DP_DOWNSTREAM_PORT_STATUS_CHANGED (1 << 6) > -#define DP_LINK_STATUS_UPDATED (1 << 7) > +# define DP_INTERLANE_ALIGN_DONE (1 << 0) > +# define DP_DOWNSTREAM_PORT_STATUS_CHANGED (1 << 6) > +# define DP_LINK_STATUS_UPDATED (1 << 7) > > #define DP_SINK_STATUS 0x205 > - > -#define DP_RECEIVE_PORT_0_STATUS (1 << 0) > -#define DP_RECEIVE_PORT_1_STATUS (1 << 1) > +# define DP_RECEIVE_PORT_0_STATUS (1 << 0) > +# define DP_RECEIVE_PORT_1_STATUS (1 << 1) > > #define DP_ADJUST_REQUEST_LANE0_1 0x206 > #define DP_ADJUST_REQUEST_LANE2_3 0x207 Please make a separate patch for whitespace cleanups... Otherwise, these changes all match the DP 1.1a spec that I compared them with. Reviewed-by: Keith Packard <[email protected]> -- [email protected]
pgpUYcNDDiX8X.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
