On Wed, 27 Jul 2011 10:53:28 -0700, Jesse Barnes <[email protected]> 
wrote:

> +     len = snprintf(buf, sizeof (buf),
> +                    "freq: %d\n", dev_priv->max_delay * 50);

should probably be 'Max frequency' too?

> +
> +     if (len > sizeof (buf))
> +             len = sizeof (buf);
> +
> +     return simple_read_from_buffer(ubuf, max, ppos, buf, len);
> +}
> +
> +static ssize_t
> +i915_max_freq_write(struct file *filp,
> +               const char __user *ubuf,
> +               size_t cnt,
> +               loff_t *ppos)
> +{
> +     struct drm_device *dev = filp->private_data;
> +     struct drm_i915_private *dev_priv = dev->dev_private;
> +     char buf[20];
> +     int val = 1;
> +
> +     if (cnt > 0) {
> +             if (cnt > sizeof (buf) - 1)
> +                     return -EINVAL;
> +
> +             if (copy_from_user(buf, ubuf, cnt))
> +                     return -EFAULT;
> +             buf[cnt] = 0;
> +
> +             val = simple_strtoul(buf, NULL, 0);
> +     }
> +
> +     DRM_DEBUG_DRIVER("Manually setting freq to %d\n", val);

And 'max freq' here too.

Otherwise, this seems useful to me too.

-- 
[email protected]

Attachment: pgpG0zF3oHvsB.pgp
Description: PGP signature

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to