On Sun, 04 Sep 2011 10:03:21 +0100 Chris Wilson <[email protected]> wrote:
> On Sat, 3 Sep 2011 20:24:15 -0700, Ben Widawsky <[email protected]> > wrote: > > I couldn't reproduce this one, but... Interrupt mask state is lost > > if three interrupts occur before the workqueue has run. > > > > Should be straight forward to reproduce even without SMP. I'm pretty > > sure Dan Vetter was trying to explain this to me, and I couldn't > > get it. My solution I think is different than his though. > > This logic is now duplicated in ivybridge_irq_handler(). This simply > fits the scenario Daniel described, whilst also fitting in with our > understanding of IMR, IER and IIR. (A big assumption ;-) > > Reported-by: Soeren Sonnenburg <[email protected]> > Reviewed-by: Chris Wilson <[email protected]> > -Chris > I completely screwed this one up because I was tired. Chris sent me this exact patch, which I told him was wrong, and then proceeded to rewrite the same thing on my own. Chris, I suggest you resubmit what you sent me privately with my reviewed by, and please accept my apology. I am nak'ing my patch. Ben _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
