On Wed, Sep 14, 2011 at 08:32:47PM -0700, Ben Widawsky wrote: > While I think the previous code is correct, it was hard to follow and > hard to debug. Since we already have a ring abstraction, might as well > use it to handle the semaphore updates and compares. > > I don't expect this code to make semaphores better or worse, but you > never know... > > v2: > Remove magic per Keith's suggestions. > Ran Daniel's gem_ring_sync_loop test on this. > > v3: > Ignored one of Keith's suggestions. > > v4: > Removed some bloat per Daniel's recommendation.
Just to clarify, I think I like the existing code a bit better than what the code looked like with Daniel's other recommendation to cut out the per ring sync_to function. If he shows me something good, there will be a v5, I guess. _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
