On Sun, Oct 30, 2011 at 06:50:05PM -0700, Ben Widawsky wrote: > Ah, just saw patch 5... I guess I find this a little weird way to break > it up, but I think I did a much worse job in my patches.
Safe when the change is really small (i.e. a few one-liner hunks), always separate the refactor from the actual code change. It's just damn hard to spot a small functional change amid tons of code movement, making proper review impossible. That's also the reason I'll only ever smash an acked-by on top of a massive refactor - you can't review that kind of stuff without completely redoing the patch yourself. -Daniel -- Daniel Vetter Mail: [email protected] Mobile: +41 (0)79 365 57 48 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
