On Tue, Nov 1, 2011 at 7:54 PM, Matthew Garrett <[email protected]> wrote: > Again, adding arbitrary constants without any explanation for why you're > making this the default really isn't acceptable. We have no way to > determine whether fixing one machine is worth making things worse for > another.
The default is applied only in the case where no valid register settings have been found to be initialized by the BIOS. Hence the only systems that will be affected by this patch are the ones whose backlight PWM is already improperly configured. Hence, I think affected systems will either benefit from this change or be made no worse, as they were already broken. That said, I do think the patch could use some more explanation in comments and the patch description. _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
