On Wed, 4 Jan 2012 08:52:34 -0800, Jesse Barnes <[email protected]> 
wrote:
> On Tue,  3 Jan 2012 19:10:00 -0800
> Eric Anholt <[email protected]> wrote:
> 
> > ---
> > 
> > This syncs the code up to the kernel as of the gen7 SOL changes.  It
> > would be nice if doing this was just a straight copy of the kernel
> > code -- there are two diffs left out.  One is this hunk:
> > 
> > -#ifdef __KERNEL__
> > -/* For use by IPS driver */
> > -extern unsigned long i915_read_mch_val(void);
> > -extern bool i915_gpu_raise(void);
> > -extern bool i915_gpu_lower(void);
> > -extern bool i915_gpu_busy(void);
> > -extern bool i915_gpu_turbo_disable(void);
> > -#endif
> > 
> > Does anyone see any real reason to be dropping this?
> > 
> > The other is removing the sparse __user annotations on the structs.
> > Could we just patch the kernel to #define it away for userland, so we
> > could make updating this file just a matter of "cp"?
> 
> Having just done this locally, I'm in favor.  The stuff under
> __KERNEL__ should be harmless; don't see why we can't just copy it.
> 
> For the __user define, we must be missing a compiler.h include
> somewhere in the libdrm case.  If you explicitly include it do the
> errors go away?

What version of POSIX is compiler.h part of?  Remember that this is
userland code built across OSes (as much as we try to forget that).

Attachment: pgp4PZrWcmpAW.pgp
Description: PGP signature

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to