On Sat, 3 Mar 2012 16:22:45 +0100, Julien Cristau <jcris...@debian.org> wrote:
> On Tue, Feb 21, 2012 at 21:11:07 +0000, Chris Wilson wrote:
>
> > On Tue, 21 Feb 2012 12:59:37 -0800, Kenneth Graunke <kenn...@whitecape.org>
> > wrote:
> > > @@ -1828,6 +1829,9 @@ drm_intel_gem_bo_mrb_exec2(drm_intel_bo *bo, int
> > > used,
> > > execbuf.rsvd1 = 0;
> > > execbuf.rsvd2 = 0;
> > >
> > > + if (getenv("INTEL_DEVID_OVERRIDE"))
> > > + goto skip_execution;
> >
> > I'm not thrilled about calling getenv() for every execbuffer. And what
> > about the original execbuffer path?
>
> I'm not thrilled about allowing the user to modify X server behaviour
> with an env variable. This is setuid root after all. I guess this also
> applies to the existing calls to getenv in the dri driver.Yeah, this seems roughly of the same class as the many environment variables we've always had. I'm going to take a shot at disabling a bunch under setuid, though.
pgpHDa9fmvsKx.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
