On Thu, Apr 05, 2012 at 01:55:12PM +0200, Daniel Vetter wrote: > On Thu, Apr 5, 2012 at 13:04, Konstantin Belousov <[email protected]> wrote: > > it seems that the loop in i915_gem_init_aliasing_ppgtt() over pd_entries > > that calculates pt_addr does nothing after the commit 55a254ac in the > > !dmar case. Would it be better to move needs_dmar check over the whole > > loop ? > > For the !dmar case we still need need to compute the physical address > with page_to_phys, so I think the loop is needed.
Does linux' page_to_phys() has side effects ? I just fail to see where the pt_addr is used after the calculation.
pgpV4A3Or7U3U.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
